summaryrefslogtreecommitdiff
path: root/qa/qa/specs/features/browser_ui/6_release
diff options
context:
space:
mode:
authorMark Lapierre <mlapierre@gitlab.com>2019-01-10 16:53:06 -0500
committerMark Lapierre <mlapierre@gitlab.com>2019-01-11 09:31:57 -0500
commit501a43199e85cc77b15986096717067d47290e80 (patch)
tree3aa58f0ebc06da3e48e2cd89d56c4c324a4baee5 /qa/qa/specs/features/browser_ui/6_release
parent6b2f81f6078e96f081154c50dc25e54fe7c09d6f (diff)
downloadgitlab-ce-501a43199e85cc77b15986096717067d47290e80.tar.gz
Fix deploy key test
Fetch a specific key's fingerprint instead of all fingerprints. Check for the specific key by title and expected fingerprint. This avoids the use of `all`, which can be unreliable.
Diffstat (limited to 'qa/qa/specs/features/browser_ui/6_release')
-rw-r--r--qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb10
1 files changed, 8 insertions, 2 deletions
diff --git a/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb b/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb
index 84757f25379..6f39a755392 100644
--- a/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb
+++ b/qa/qa/specs/features/browser_ui/6_release/deploy_key/add_deploy_key_spec.rb
@@ -5,7 +5,7 @@ module QA
describe 'Deploy key creation' do
it 'user adds a deploy key' do
Runtime::Browser.visit(:gitlab, Page::Main::Login)
- Page::Main::Login.act { sign_in_using_credentials }
+ Page::Main::Login.perform(&:sign_in_using_credentials)
key = Runtime::Key::RSA.new
deploy_key_title = 'deploy key title'
@@ -16,7 +16,13 @@ module QA
resource.key = deploy_key_value
end
- expect(deploy_key.fingerprint).to eq(key.fingerprint)
+ expect(deploy_key.fingerprint).to eq key.fingerprint
+
+ Page::Project::Settings::Repository.perform do |setting|
+ setting.expand_deploy_keys do |keys|
+ expect(keys).to have_key(deploy_key_title, key.fingerprint)
+ end
+ end
end
end
end