diff options
| author | Dylan Griffith <dyl.griffith@gmail.com> | 2019-02-15 01:25:18 +0000 |
|---|---|---|
| committer | Dylan Griffith <dyl.griffith@gmail.com> | 2019-02-15 13:38:12 -0600 |
| commit | 8cb772bc414269e8c0dccae7c38fab0c58927040 (patch) | |
| tree | cd01851690bf1c5da76c5f1c2f2744980917da94 /qa/qa/specs/features/browser_ui/6_release | |
| parent | 4a7948ea2ef1836f5b823b1b97d6ae0e8867e9ac (diff) | |
| download | gitlab-ce-8cb772bc414269e8c0dccae7c38fab0c58927040.tar.gz | |
Fix waiting for spec failures in QA Build specs
The waiting logic on the build page was flaky or just not really
working. Waiting for the spinner to not be present seemed to not work
and we were regularly still seeing the spinner in our build failure
screenshots (eg.
https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/161759351 )
Diffstat (limited to 'qa/qa/specs/features/browser_ui/6_release')
| -rw-r--r-- | qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb b/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb index 2375aa4ce91..2f885b330d3 100644 --- a/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb +++ b/qa/qa/specs/features/browser_ui/6_release/deploy_key/clone_using_deploy_key_spec.rb @@ -95,7 +95,9 @@ module QA Page::Project::Pipeline::Show.perform(&:go_to_first_job) Page::Project::Job::Show.perform do |job| - expect(job).to be_successful, "Job status did not become \"passed\"." + expect(job).to be_loaded + expect(job).to be_completed + expect(job).to be_successful expect(job.output).to include(sha1sum) end end |