Succeed or fail fast based on job status first

Also, move wait block into the correct page block.

1 files changed, 4 insertions, 8 deletions

diff --git a/qa/qa/specs/features/project/deploy_key_clone_spec.rb b/qa/qa/specs/features/project/deploy_key_clone_spec.rb
index 98ea86bf75e..bf8fa230244 100644
--- a/qa/qa/specs/features/project/deploy_key_clone_spec.rb
+++ b/qa/qa/specs/features/project/deploy_key_clone_spec.rb
@@ -87,16 +87,12 @@ module QA
         Page::Project::Show.act { wait_for_push }
         Page::Menu::Side.act { click_ci_cd_pipelines }
         Page::Project::Pipeline::Index.act { go_to_latest_pipeline }
-
-        Page::Project::Pipeline::Show.act do
-          go_to_first_job
-
-          wait do
-            !has_content?('running')
-          end
-        end
+        Page::Project::Pipeline::Show.act { go_to_first_job }
 
         Page::Project::Job::Show.perform do |job|
+          job.wait(reload: false) { job.completed? }
+
+          expect(job.passed?).to be_truthy, "Job status did not become \"passed\"."
           expect(job.output).to include(sha1sum)
         end
       end