Fix a sanity framework testqa-fix-sanity-framework-test

On first load, the login page displays the "Change your password" tab,
not the "Sign in" tab. We now assert on the presence of a text that's
always on this page.

Note that in EE, since a license is added in the `#perform_before_hooks`
method, the password is changed so that when we visit the login page,
the "Sign in" tab is displayed as expected. That's why only the CE job
failed to pass in
https://gitlab.com/gitlab-org/gitlab-qa/pipelines/31060920.

Signed-off-by: Rémy Coutable <remy@rymai.me>

1 files changed, 1 insertions, 3 deletions

diff --git a/qa/qa/specs/features/sanity/framework_spec.rb b/qa/qa/specs/features/sanity/framework_spec.rb
index ee9d068eb3a..aae0f0ade71 100644
--- a/qa/qa/specs/features/sanity/framework_spec.rb
+++ b/qa/qa/specs/features/sanity/framework_spec.rb
@@ -6,9 +6,7 @@ module QA
       it 'succeeds' do
         Runtime::Browser.visit(:gitlab, Page::Main::Login)
 
-        Page::Main::Login.perform do |main_login|
-          expect(main_login.sign_in_tab?).to be(true)
-        end
+        expect(page).to have_text('Open source software to collaborate on code')
       end
     end