summaryrefslogtreecommitdiff
path: root/qa/qa
diff options
context:
space:
mode:
authorWalmyr <walmyr@gitlab.com>2019-04-04 21:52:46 +0000
committerMark Lapierre <mlapierre@gitlab.com>2019-04-04 21:52:46 +0000
commit7aa36864c5cd5feb178f5fc83c3d69af10e58e9e (patch)
tree012d8925b1d973d2377ca82d75fb6f79be42d26c /qa/qa
parent1ddd9eff6dd931b0689743d571b7bf3fccedb979 (diff)
downloadgitlab-ce-7aa36864c5cd5feb178f5fc83c3d69af10e58e9e.tar.gz
Replace comment by variable
Instead of having a comment describing what a specific value is, better to have a variable with a meaningful name.
Diffstat (limited to 'qa/qa')
-rw-r--r--qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb b/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb
index 9f34e4218c1..caa9be341b4 100644
--- a/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb
+++ b/qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb
@@ -8,11 +8,11 @@ module QA
Page::Main::Login.act { sign_in_using_credentials }
deploy_token_name = 'deploy token name'
- deploy_token_expires_at = Date.today + 7 # 1 Week from now
+ one_week_from_now = Date.today + 7
deploy_token = Resource::DeployToken.fabricate! do |resource|
resource.name = deploy_token_name
- resource.expires_at = deploy_token_expires_at
+ resource.expires_at = one_week_from_now
end
expect(deploy_token.username.length).to be > 0