diff options
author | Rémy Coutable <remy@rymai.me> | 2018-10-15 14:23:43 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-10-15 17:55:53 +0200 |
commit | 1db52c79ad0b2499fb10fb0c68098c3994441642 (patch) | |
tree | 31f37fa88b1633143f4d3ed9f306b3b6d86fca6f /qa/spec | |
parent | 02c47f2f73ac2d5a33b9a6c971668a38397b4910 (diff) | |
download | gitlab-ce-1db52c79ad0b2499fb10fb0c68098c3994441642.tar.gz |
Disable the QA/ElementWithPattern cop for existing offenses
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'qa/spec')
-rw-r--r-- | qa/spec/page/base_spec.rb | 6 | ||||
-rw-r--r-- | qa/spec/page/view_spec.rb | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/qa/spec/page/base_spec.rb b/qa/spec/page/base_spec.rb index 52daa9697ee..076a8087db5 100644 --- a/qa/spec/page/base_spec.rb +++ b/qa/spec/page/base_spec.rb @@ -9,12 +9,12 @@ describe QA::Page::Base do subject do Class.new(described_class) do view 'path/to/some/view.html.haml' do - element :something, 'string pattern' - element :something_else, /regexp pattern/ + element :something, 'string pattern' # rubocop:disable QA/ElementWithPattern + element :something_else, /regexp pattern/ # rubocop:disable QA/ElementWithPattern end view 'path/to/some/_partial.html.haml' do - element :another_element, 'string pattern' + element :another_element, 'string pattern' # rubocop:disable QA/ElementWithPattern end end end diff --git a/qa/spec/page/view_spec.rb b/qa/spec/page/view_spec.rb index 34d2ff11447..d7b3ccd316d 100644 --- a/qa/spec/page/view_spec.rb +++ b/qa/spec/page/view_spec.rb @@ -8,8 +8,8 @@ describe QA::Page::View do describe '.evaluate' do it 'evaluates a block and returns a DSL object' do results = described_class.evaluate do - element :something, 'my pattern' - element :something_else, /another pattern/ + element :something + element :something_else end expect(results.elements.size).to eq 2 |