summaryrefslogtreecommitdiff
path: root/qa
diff options
context:
space:
mode:
authorWalmyr Lima <walmyr@gitlab.com>2019-07-18 14:52:21 +0200
committerWalmyr Lima <walmyr@gitlab.com>2019-07-18 14:52:21 +0200
commitc74164167a6e9c8a5da5beb6c3266586837797d0 (patch)
treefb2eb472f348a797908ed36b5fed538a11e4d277 /qa
parent9967b2d1ee3644ed22fb441cc754f4e6764a7718 (diff)
downloadgitlab-ce-c74164167a6e9c8a5da5beb6c3266586837797d0.tar.gz
Better scope end-to-end testqa/better-scope-another-test
Move test pre-conditions to before block, remove unnecessary expectation, and leave only the test steps and verifications in the it block.
Diffstat (limited to 'qa')
-rw-r--r--qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
index af9514008f9..6f5b6893248 100644
--- a/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
+++ b/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
@@ -5,7 +5,7 @@ module QA
describe 'filter issue comments activities' do
let(:issue_title) { 'issue title' }
- it 'user filters comments and activities in an issue' do
+ before do
Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.perform(&:sign_in_using_credentials)
@@ -14,9 +14,9 @@ module QA
end
issue.visit!
+ end
- expect(page).to have_content(issue_title)
-
+ it 'user filters comments and activities in an issue' do
Page::Project::Issue::Show.perform do |show_page|
my_own_comment = "My own comment"
made_the_issue_confidential = "made the issue confidential"