diff options
| author | Paul Slaughter <pslaughter@gitlab.com> | 2019-04-04 02:44:16 -0500 |
|---|---|---|
| committer | Paul Slaughter <pslaughter@gitlab.com> | 2019-04-04 10:00:44 -0500 |
| commit | bd1122ee2fd5c8083c945390a1593b2b5774d8a1 (patch) | |
| tree | 99cd3ca658befdd7726da379577dcea0f40ecfcf /qa | |
| parent | 7926384ff32b9ad8833dcfffc9bb87d036c4bd21 (diff) | |
| download | gitlab-ce-bd1122ee2fd5c8083c945390a1593b2b5774d8a1.tar.gz | |
Fix vue render error for IDE status bar
**What?**
A Vue warning that `ide_status_bar` sent a `Boolean` to a `String`
property (`img-src).
**What was the fix?**
Previously, `latestPipeline` could be one of the following values:
| | |
|----------|--------|
| `null` | The pipeline hasn't loaded yet |
| `false` | The pipeline has loaded, but nothing was returned. |
| `Object` | The piepline has loaded. |
Giving a semantic meaning to different falsey values hurts
maintainability. This commit fixes the above problem by removing the
`false` value and introducing a `hasLoadedPipeline` state property.
Diffstat (limited to 'qa')
0 files changed, 0 insertions, 0 deletions