summaryrefslogtreecommitdiff
path: root/qa
diff options
context:
space:
mode:
authorddavison <ddavison@gitlab.com>2019-05-28 09:16:35 -0700
committerddavison <ddavison@gitlab.com>2019-05-28 09:20:34 -0700
commitee17fb03695a7b9247219eaaf203829d8dd6cc18 (patch)
treef3421ff3351f3fdfa251f2dc08f5f07a43af3e61 /qa
parent43b35b6c1108d3edd228206f2e4a78bdf9b3dbb9 (diff)
downloadgitlab-ce-ee17fb03695a7b9247219eaaf203829d8dd6cc18.tar.gz
Iteration for _field being the well-formed element
Since number fields, text boxes, text areas are editable lets use _field as the vague descriptor
Diffstat (limited to 'qa')
-rw-r--r--qa/docs/guidelines.md15
1 files changed, 7 insertions, 8 deletions
diff --git a/qa/docs/guidelines.md b/qa/docs/guidelines.md
index 433e66ec181..cd4b939fd71 100644
--- a/qa/docs/guidelines.md
+++ b/qa/docs/guidelines.md
@@ -59,9 +59,10 @@ We follow a simple formula roughly based on hungarian notation.
- `_link`
- `_tab`
- `_dropdown`
- - `_text`
+ - `_field`
- `_checkbox`
- `_radio`
+ - `_content`
*Note: This list is a work in progress. This list will eventually be the end-all enumeration of all available types.
I.e., any element that does not end with something in this list is bad form.*
@@ -74,18 +75,16 @@ view '...' do
element :edit_button
element :notes_tab
element :squash_checkbox
+ element :username_field
+ element :issue_title_content
end
```
**Bad**
```ruby
-view '...' do
- # `_field` should be `_text`.
- # Per the W3C Spec, field is too vague. `type='password'`, `type='hidden'` etc.
- element :login_field
-
- # `_confirmation` should be `_text`. what sort of confirmation? a checkbox confirmation? no real way to disambiguate.
- # an appropriate replacement would be `element :password_confirmation_text`
+view '...' do
+ # `_confirmation` should be `_field`. what sort of confirmation? a checkbox confirmation? no real way to disambiguate.
+ # an appropriate replacement would be `element :password_confirmation_field`
element :password_confirmation
# `clone_options` is too vague. If it's a dropdown menu, it should be `clone_dropdown`.