summaryrefslogtreecommitdiff
path: root/qa
diff options
context:
space:
mode:
authorddavison <ddavison@gitlab.com>2019-04-30 17:02:20 -0700
committerddavison <ddavison@gitlab.com>2019-05-20 12:35:51 -0700
commit83cfd20ca86d5f0992438c44707b074a711b7752 (patch)
tree80cdf95721172764c79e7f39b7ad6f16ed11dcfc /qa
parent3f4a1082ae5788d4135bf01a748036ff03656d32 (diff)
downloadgitlab-ce-83cfd20ca86d5f0992438c44707b074a711b7752.tar.gz
Remove blocks from Runtime::Browser.visit calls within Mattermost testsqa-extend-click-visit-actions
Use .perform instead of .act in Mattermost test Signed-off-by: ddavison <ddavison@gitlab.com>
Diffstat (limited to 'qa')
-rw-r--r--qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb14
1 files changed, 6 insertions, 8 deletions
diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb
index b1d641b507f..67610b62ed7 100644
--- a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb
+++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_mattermost_via_gitlab_spec.rb
@@ -4,16 +4,14 @@ module QA
context 'Manage', :orchestrated, :mattermost do
describe 'Mattermost login' do
it 'user logs into Mattermost using GitLab OAuth' do
- Runtime::Browser.visit(:gitlab, Page::Main::Login) do
- Page::Main::Login.act { sign_in_using_credentials }
+ Runtime::Browser.visit(:gitlab, Page::Main::Login)
+ Page::Main::Login.perform(&:sign_in_using_credentials)
- Runtime::Browser.visit(:mattermost, Page::Mattermost::Login) do
- Page::Mattermost::Login.act { sign_in_using_oauth }
+ Runtime::Browser.visit(:mattermost, Page::Mattermost::Login)
+ Page::Mattermost::Login.perform(&:sign_in_using_oauth)
- Page::Mattermost::Main.perform do |page|
- expect(page).to have_content(/(Welcome to: Mattermost|Logout GitLab Mattermost)/)
- end
- end
+ Page::Mattermost::Main.perform do |page|
+ expect(page).to have_content(/(Welcome to: Mattermost|Logout GitLab Mattermost)/)
end
end
end