diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-06 21:08:48 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-06 21:08:48 +0000 |
commit | a89cb5cbdd832d4d9e80517973aceda6bc0a3856 (patch) | |
tree | 574475bd0901a2f8906d36a4728b8bbb95b41e1c /qa | |
parent | 0d6fa033121a9bef708b8f2de186c4034c61d4a3 (diff) | |
download | gitlab-ce-a89cb5cbdd832d4d9e80517973aceda6bc0a3856.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'qa')
17 files changed, 20 insertions, 20 deletions
diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb index 6c7f80705e2..57d2c02a27b 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/check_mentions_for_xss_spec.rb @@ -3,7 +3,7 @@ module QA context 'Plan', :reliable do describe 'check xss occurence in @mentions in issues', :requires_admin do - it 'user mentions a user in comment' do + it 'mentions a user in a comment' do QA::Runtime::Env.personal_access_token = QA::Runtime::Env.admin_personal_access_token unless QA::Runtime::Env.personal_access_token diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/close_issue_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/close_issue_spec.rb index fd00e010b85..d075dc742e2 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/close_issue_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/close_issue_spec.rb @@ -18,7 +18,7 @@ module QA push_commit('Initial commit') end - it 'user closes an issue by pushing commit' do + it 'closes an issue by pushing a commit' do push_commit("Closes ##{issue_id}", false) issue.visit! diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb index a2b7904a84d..33d2c7026b3 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb @@ -17,7 +17,7 @@ module QA end end - it 'user collapses and expands reply for comments in an issue' do + it 'collapses and expands reply for comments in an issue' do Page::Project::Issue::Show.perform do |show| one_reply = "1 reply" diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb index c4a8d2c4e20..4667eb6c587 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb @@ -9,7 +9,7 @@ module QA Resource::Issue.fabricate_via_api!.visit! end - it 'user comments on an issue and edits the comment' do + it 'comments on an issue and edits the comment' do Page::Project::Issue::Show.perform do |show| first_version_of_comment = 'First version of the comment' second_version_of_comment = 'Second version of the comment' diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb index 0ea81483a66..1c741a2e8bf 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb @@ -7,7 +7,7 @@ module QA Flow::Login.sign_in end - it 'user creates an issue' do + it 'creates an issue' do issue = Resource::Issue.fabricate_via_browser_ui! Page::Project::Menu.perform(&:click_issues) @@ -27,7 +27,7 @@ module QA Resource::Issue.fabricate_via_api!.visit! end - it 'user comments on an issue with an attachment' do + it 'comments on an issue with an attachment' do Page::Project::Issue::Show.perform do |show| show.comment('See attached banana for scale', attachment: file_to_attach) diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb index f1013d38a1f..b7687f785a8 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb @@ -9,7 +9,7 @@ module QA Resource::Issue.fabricate_via_api!.visit! end - it 'user filters comments and activities in an issue' do + it 'filters comments and activities in an issue' do Page::Project::Issue::Show.perform do |show| my_own_comment = "My own comment" made_the_issue_confidential = "made the issue confidential" diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb index 6c851fd8141..9b46a066c8e 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/issue_suggestions_spec.rb @@ -13,7 +13,7 @@ module QA end.project.visit! end - it 'user sees issue suggestions when creating a new issue' do + it 'shows issue suggestions when creating a new issue' do Page::Project::Show.perform(&:go_to_new_issue) Page::Project::Issue::New.perform do |new_page| new_page.add_title("issue") diff --git a/qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb b/qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb index a76cb57b4a7..3e575517ecb 100644 --- a/qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb +++ b/qa/qa/specs/features/browser_ui/2_plan/issue/mentions_spec.rb @@ -20,7 +20,7 @@ module QA end.visit! end - it 'user mentions another user in an issue' do + it 'mentions another user in an issue' do Page::Project::Issue::Show.perform do |show| at_username = "@#{@user.username}" diff --git a/qa/spec/resource/api_fabricator_spec.rb b/qa/spec/resource/api_fabricator_spec.rb index a5ed4422f6e..eb2bdd1be64 100644 --- a/qa/spec/resource/api_fabricator_spec.rb +++ b/qa/spec/resource/api_fabricator_spec.rb @@ -120,7 +120,7 @@ describe QA::Resource::ApiFabricator do end end - context '#transform_api_resource' do + describe '#transform_api_resource' do let(:resource) do Class.new do def self.name diff --git a/qa/spec/scenario/test/integration/github_spec.rb b/qa/spec/scenario/test/integration/github_spec.rb index 6112ba7c694..b2d577bd552 100644 --- a/qa/spec/scenario/test/integration/github_spec.rb +++ b/qa/spec/scenario/test/integration/github_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::Github do - context '#perform' do + describe '#perform' do let(:env) { spy('Runtime::Env') } before do diff --git a/qa/spec/scenario/test/integration/instance_saml_spec.rb b/qa/spec/scenario/test/integration/instance_saml_spec.rb index cb8a6a630cc..15f15b2e643 100644 --- a/qa/spec/scenario/test/integration/instance_saml_spec.rb +++ b/qa/spec/scenario/test/integration/instance_saml_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::InstanceSAML do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:instance_saml] } end diff --git a/qa/spec/scenario/test/integration/kubernetes_spec.rb b/qa/spec/scenario/test/integration/kubernetes_spec.rb index cb43994b229..51ee7b9acff 100644 --- a/qa/spec/scenario/test/integration/kubernetes_spec.rb +++ b/qa/spec/scenario/test/integration/kubernetes_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::Kubernetes do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:kubernetes] } end diff --git a/qa/spec/scenario/test/integration/ldap_spec.rb b/qa/spec/scenario/test/integration/ldap_spec.rb index 86747cd8eb7..c493cde6c7a 100644 --- a/qa/spec/scenario/test/integration/ldap_spec.rb +++ b/qa/spec/scenario/test/integration/ldap_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::LDAPNoTLS do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:ldap_no_tls] } end @@ -9,7 +9,7 @@ describe QA::Scenario::Test::Integration::LDAPNoTLS do end describe QA::Scenario::Test::Integration::LDAPNoServer do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:ldap_no_server] } end @@ -17,7 +17,7 @@ describe QA::Scenario::Test::Integration::LDAPNoServer do end describe QA::Scenario::Test::Integration::LDAPTLS do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:ldap_tls] } end diff --git a/qa/spec/scenario/test/integration/mattermost_spec.rb b/qa/spec/scenario/test/integration/mattermost_spec.rb index 4e75e72f4d2..4452e890ebe 100644 --- a/qa/spec/scenario/test/integration/mattermost_spec.rb +++ b/qa/spec/scenario/test/integration/mattermost_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::Mattermost do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:args) { %w[gitlab_address mattermost_address] } let(:args) do diff --git a/qa/spec/scenario/test/integration/oauth_spec.rb b/qa/spec/scenario/test/integration/oauth_spec.rb index c1c320be576..ab7ea905a29 100644 --- a/qa/spec/scenario/test/integration/oauth_spec.rb +++ b/qa/spec/scenario/test/integration/oauth_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::OAuth do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:oauth] } end diff --git a/qa/spec/scenario/test/integration/object_storage_spec.rb b/qa/spec/scenario/test/integration/object_storage_spec.rb index 2b7188223e0..8b4367bee32 100644 --- a/qa/spec/scenario/test/integration/object_storage_spec.rb +++ b/qa/spec/scenario/test/integration/object_storage_spec.rb @@ -1,7 +1,7 @@ # frozen_string_literal: true describe QA::Scenario::Test::Integration::ObjectStorage do - context '#perform' do + describe '#perform' do it_behaves_like 'a QA scenario class' do let(:tags) { [:object_storage] } end diff --git a/qa/spec/specs/runner_spec.rb b/qa/spec/specs/runner_spec.rb index 3d98f03a982..1a3efe0b46c 100644 --- a/qa/spec/specs/runner_spec.rb +++ b/qa/spec/specs/runner_spec.rb @@ -11,7 +11,7 @@ describe QA::Specs::Runner do end end - context '#perform' do + describe '#perform' do before do allow(QA::Runtime::Browser).to receive(:configure!) end |