diff options
| author | Walmyr <walmyr@gitlab.com> | 2019-04-22 07:11:45 +0000 |
|---|---|---|
| committer | Ramya Authappan <rauthappan@gitlab.com> | 2019-04-22 07:11:45 +0000 |
| commit | 2fba2adeaddd3c357242d1aec6492e43cbef5dcf (patch) | |
| tree | 719e3b2e47e9aa121939cc08744bb95f8705823a /qa | |
| parent | 10bf3bbc904c96d5d7633f58cb93cf6927e18c8e (diff) | |
| download | gitlab-ce-2fba2adeaddd3c357242d1aec6492e43cbef5dcf.tar.gz | |
Remove unnecessary comments from login tests
The comments were TODOs but there were no explanation of what
needed to be done.
Also, I think the expectation describes very well how it checks
that the user is logged in.
Finally, as Robert C. Martin said once:
"After you check in a TODO comment it turns into a DON'T DO"
Diffstat (limited to 'qa')
3 files changed, 0 insertions, 10 deletions
diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb index 71c06b3410f..cf225a639b6 100644 --- a/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb +++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb @@ -7,16 +7,12 @@ module QA Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.act { sign_in_using_credentials } - # TODO, since `Signed in successfully` message was removed - # this is the only way to tell if user is signed in correctly. - # Page::Main::Menu.perform do |menu| expect(menu).to have_personal_area end Page::Main::Menu.perform do |menu| menu.sign_out - expect(menu).not_to have_personal_area end Page::Main::Login.perform do |form| diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb index a397df03bd2..72dde4e5bd8 100644 --- a/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb +++ b/qa/qa/specs/features/browser_ui/1_manage/login/log_into_gitlab_via_ldap_spec.rb @@ -7,9 +7,6 @@ module QA Runtime::Browser.visit(:gitlab, Page::Main::Login) Page::Main::Login.act { sign_in_using_credentials } - # TODO, since `Signed in successfully` message was removed - # this is the only way to tell if user is signed in correctly. - # Page::Main::Menu.perform do |menu| expect(menu).to have_personal_area end diff --git a/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb b/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb index 185837edacf..a0e3fe0d91a 100644 --- a/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb +++ b/qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb @@ -7,9 +7,6 @@ module QA Resource::User.fabricate_via_browser_ui! - # TODO, since `Signed in successfully` message was removed - # this is the only way to tell if user is signed in correctly. - # Page::Main::Menu.perform do |menu| expect(menu).to have_personal_area end |