diff options
author | Mark Lapierre <mlapierre@gitlab.com> | 2019-05-31 09:42:28 +1000 |
---|---|---|
committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-05-31 09:42:28 +1000 |
commit | 3f51df04ed0389154d1a17dbf899bd050ff68b52 (patch) | |
tree | 6b82764cbc7fcf12d017b05e0792ea3ac36240dc /qa | |
parent | 8ab0db4e8f74457c419e913dc6af6296a0a9fa52 (diff) | |
download | gitlab-ce-3f51df04ed0389154d1a17dbf899bd050ff68b52.tar.gz |
Allow login validation before blockqa-fix-api-client-login-validation
Removes a block so that the login page is validated before the block,
while the login page is still present, instead of after it when the
login page is long gone
Diffstat (limited to 'qa')
-rw-r--r-- | qa/qa/runtime/api/client.rb | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/qa/qa/runtime/api/client.rb b/qa/qa/runtime/api/client.rb index 58de01705d7..40a3bc85195 100644 --- a/qa/qa/runtime/api/client.rb +++ b/qa/qa/runtime/api/client.rb @@ -25,15 +25,12 @@ module QA private def create_personal_access_token - if @is_new_session - Runtime::Browser.visit(@address, Page::Main::Login) { do_create_personal_access_token } - else - do_create_personal_access_token - end + Runtime::Browser.visit(@address, Page::Main::Login) if @is_new_session + do_create_personal_access_token end def do_create_personal_access_token - Page::Main::Login.act { sign_in_using_credentials } + Page::Main::Login.perform(&:sign_in_using_credentials) Resource::PersonalAccessToken.fabricate!.access_token end end |