Add latest changes from gitlab-org/gitlab@14-10-stable-eev14.10.0-rc42

1 files changed, 43 insertions, 0 deletions

diff --git a/rubocop/cop/gitlab/avoid_feature_category_not_owned.rb b/rubocop/cop/gitlab/avoid_feature_category_not_owned.rb
new file mode 100644
index 00000000000..fb790f44a96
--- /dev/null
+++ b/rubocop/cop/gitlab/avoid_feature_category_not_owned.rb
@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require_relative '../../code_reuse_helpers'
+
+module RuboCop
+  module Cop
+    module Gitlab
+      class AvoidFeatureCategoryNotOwned < RuboCop::Cop::Cop
+        include ::RuboCop::CodeReuseHelpers
+
+        MSG = 'Avoid adding new endpoints with `feature_category :not_owned`. See https://docs.gitlab.com/ee/development/feature_categorization'
+        RESTRICT_ON_SEND = %i[feature_category get post put patch delete].freeze
+
+        def_node_matcher :feature_category_not_owned?, <<~PATTERN
+          (send _ :feature_category (sym :not_owned) ...)
+        PATTERN
+
+        def_node_matcher :feature_category_not_owned_api?, <<~PATTERN
+          (send nil? {:get :post :put :patch :delete} _
+            (hash <(pair (sym :feature_category) (sym :not_owned)) ...>)
+          )
+        PATTERN
+
+        def on_send(node)
+          return unless file_needs_feature_category?(node)
+          return unless setting_not_owned?(node)
+
+          add_offense(node, location: :expression)
+        end
+
+        private
+
+        def file_needs_feature_category?(node)
+          in_controller?(node) || in_worker?(node) || in_api?(node)
+        end
+
+        def setting_not_owned?(node)
+          feature_category_not_owned?(node) || feature_category_not_owned_api?(node)
+        end
+      end
+    end
+  end
+end