diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-11-18 13:16:36 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-11-18 13:16:36 +0000 |
commit | 311b0269b4eb9839fa63f80c8d7a58f32b8138a0 (patch) | |
tree | 07e7870bca8aed6d61fdcc810731c50d2c40af47 /rubocop/cop/qa | |
parent | 27909cef6c4170ed9205afa7426b8d3de47cbb0c (diff) | |
download | gitlab-ce-311b0269b4eb9839fa63f80c8d7a58f32b8138a0.tar.gz |
Add latest changes from gitlab-org/gitlab@14-5-stable-eev14.5.0-rc42
Diffstat (limited to 'rubocop/cop/qa')
-rw-r--r-- | rubocop/cop/qa/duplicate_testcase_link.rb | 46 |
1 files changed, 46 insertions, 0 deletions
diff --git a/rubocop/cop/qa/duplicate_testcase_link.rb b/rubocop/cop/qa/duplicate_testcase_link.rb new file mode 100644 index 00000000000..82549707a83 --- /dev/null +++ b/rubocop/cop/qa/duplicate_testcase_link.rb @@ -0,0 +1,46 @@ +# frozen_string_literal: true + +module RuboCop + module Cop + module QA + # This cop checks for duplicate testcase links across e2e specs + # + # @example + # + # # bad + # it 'some test', testcase: '(...)/quality/test_cases/1892' + # it 'another test, testcase: '(...)/quality/test_cases/1892' + # + # # good + # it 'some test', testcase: '(...)/quality/test_cases/1892' + # it 'another test, testcase: '(...)/quality/test_cases/1894' + class DuplicateTestcaseLink < RuboCop::Cop::Cop + MESSAGE = "Don't reuse the same testcase link in different tests. Replace one of `%s`." + + @testcase_set = Set.new + + def_node_matcher :duplicate_testcase_link, <<~PATTERN + (block + (send nil? ... + ... + (hash + (pair + (sym :testcase) + (str $_))...)...)...) + PATTERN + + def on_block(node) + duplicate_testcase_link(node) do |link| + break unless self.class.duplicate?(link) + + add_offense(node, message: MESSAGE % link) + end + end + + def self.duplicate?(link) + !@testcase_set.add?(link) + end + end + end + end +end |