diff options
| author | Sean McGivern <sean@gitlab.com> | 2018-04-09 12:19:18 +0100 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2018-04-09 12:47:04 +0100 |
| commit | 4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24 (patch) | |
| tree | 6c151944cf2791fe4526633603f3e888268ae431 /rubocop/rubocop.rb | |
| parent | 20fdbbe86a6cffbf467f08d50a0d8ef0f5c87f50 (diff) | |
| download | gitlab-ce-4ef3e3491e2ecc34e7f4de1221d5ad7b8b4a1e24.tar.gz | |
Add cop for has_many :through without disabled autoloadingfix-n-plus-one-when-getting-notification-settings-for-recipients
Goldiloader is great, but has several issues with has_many :through relations:
* https://github.com/salsify/goldiloader/issues/12
* https://github.com/salsify/goldiloader/issues/14
* https://github.com/salsify/goldiloader/issues/18
Rather than try to figure out which applies in each case, we should just do the
drudge work of manually disabling autoloading for all relations of this type. We
can always use regular preloading for specific cases, but this way we avoid
generating invalid queries through Goldiloader's magic.
Diffstat (limited to 'rubocop/rubocop.rb')
| -rw-r--r-- | rubocop/rubocop.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/rubocop/rubocop.rb b/rubocop/rubocop.rb index 406ec95ffc9..c2254332e7d 100644 --- a/rubocop/rubocop.rb +++ b/rubocop/rubocop.rb @@ -1,7 +1,8 @@ # rubocop:disable Naming/FileName +require_relative 'cop/gitlab/has_many_through_scope' +require_relative 'cop/gitlab/httparty' require_relative 'cop/gitlab/module_with_instance_variables' require_relative 'cop/gitlab/predicate_memoization' -require_relative 'cop/gitlab/httparty' require_relative 'cop/include_sidekiq_worker' require_relative 'cop/line_break_around_conditional_block' require_relative 'cop/migration/add_column' |