diff options
| author | Sean McGivern <sean@gitlab.com> | 2017-11-17 13:38:14 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2017-11-17 16:56:50 +0000 |
| commit | d8be981466e2a794b42996960f1fdb91e560a707 (patch) | |
| tree | 13da4c4968dc8a2abf8ef2e531d905759521c5f5 /rubocop/rubocop.rb | |
| parent | 7910b0256e1ed3a9fdabb875c43f1ad328e1920e (diff) | |
| download | gitlab-ce-d8be981466e2a794b42996960f1fdb91e560a707.tar.gz | |
Prevent update_column_in_batches on large tables
add_column_with_default is implemented in terms of update_column_in_batches, but
update_column_in_batches can be used independently. Neither of these should be
used on the specified large tables, because they will cause issues on large
instances like GitLab.com.
This also ignores the cop for all existing migrations, renaming
AddColumnWithDefaultToLargeTable where appropriate.
Diffstat (limited to 'rubocop/rubocop.rb')
| -rw-r--r-- | rubocop/rubocop.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rubocop/rubocop.rb b/rubocop/rubocop.rb index 4ebbe010e90..a1668749dd9 100644 --- a/rubocop/rubocop.rb +++ b/rubocop/rubocop.rb @@ -7,7 +7,6 @@ require_relative 'cop/polymorphic_associations' require_relative 'cop/project_path_helper' require_relative 'cop/redirect_with_status' require_relative 'cop/migration/add_column' -require_relative 'cop/migration/add_column_with_default_to_large_table' require_relative 'cop/migration/add_concurrent_foreign_key' require_relative 'cop/migration/add_concurrent_index' require_relative 'cop/migration/add_index' @@ -20,6 +19,7 @@ require_relative 'cop/migration/reversible_add_column_with_default' require_relative 'cop/migration/safer_boolean_column' require_relative 'cop/migration/timestamps' require_relative 'cop/migration/update_column_in_batches' +require_relative 'cop/migration/update_large_table' require_relative 'cop/rspec/env_assignment' require_relative 'cop/rspec/single_line_hook' require_relative 'cop/rspec/verbose_include_metadata' |