diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-05-23 11:50:06 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-05-23 12:17:56 -0700 |
| commit | bf8f4c135a0d893defb6dd97e07b84184f5270a7 (patch) | |
| tree | 4d732d03feecdc9f6f183535994ca61071d6bc4b /rubocop | |
| parent | dd454852bc941130820b1c647a8580d56acb2a4f (diff) | |
| download | gitlab-ce-bf8f4c135a0d893defb6dd97e07b84184f5270a7.tar.gz | |
Fix OmniAuth OAuth2Generic strategy not loading
In https://github.com/rails/rails/commit/83b767ce, Rails 5.1 removed
support for using a String to specify a middleware. When the
strategy_class argument is passed from the GitLab YAML config to Devise,
Devise passes the string value straight through to Rails, and GitLab
would crash with a NoMethodError inside ActionDispatch::MiddlewareStack.
To make this OmniAuth strategy work again, we normalize the arguments by
converting the strategy_class value into an actual Class.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62216
Diffstat (limited to 'rubocop')
0 files changed, 0 insertions, 0 deletions