diff options
| author | Sean McGivern <sean@gitlab.com> | 2018-03-20 15:51:54 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2018-03-21 17:24:46 +0000 |
| commit | 39c9928cfbf5b72042755c58bd5c484551c5f1ad (patch) | |
| tree | 02d8de7ece39fa76039e4a640ada9fef147bc94d /scripts/lint-conflicts.sh | |
| parent | 398f13f39a0ce51c9ca3f223e87df88db822a396 (diff) | |
| download | gitlab-ce-39c9928cfbf5b72042755c58bd5c484551c5f1ad.tar.gz | |
Fix N+1 in `MergeRequest#merge_request_diff_for`reduce-query-count-for-mergerequestscontroller-show
Previously, this would issue a query for each unique `diff_refs_or_sha`
passed. This was because we didn't want to load other MR diffs into memory, as
they had some very large columns.
Now they are actually very small, and it's more efficient to just load them all
at once and do the finding in Ruby.
Diffstat (limited to 'scripts/lint-conflicts.sh')
0 files changed, 0 insertions, 0 deletions