summaryrefslogtreecommitdiff
path: root/scripts/review_apps/review-apps.sh
diff options
context:
space:
mode:
authorJason Plum <jplum@gitlab.com>2019-07-10 12:35:42 -0400
committerJason Plum <jplum@gitlab.com>2019-07-12 09:53:41 -0400
commit3c82d9fc8ff49ad651a66a06d3b7e787dc3a4b5d (patch)
treea6fa1429689c23514232e3f793b23e72001d4bca /scripts/review_apps/review-apps.sh
parent1dcb9b7d32574b6a66750320422f394a0aa59673 (diff)
downloadgitlab-ce-3c82d9fc8ff49ad651a66a06d3b7e787dc3a4b5d.tar.gz
ReviewApps: CI pin external-dns to 2.x version64356-pin-external-dns-version
Pin the version of deployed external-dns to `2.y.z`, using SemVer matching. (`^2.2.1`) Update the properties for the service account keys per *Upgrading to 2.0.0* of the `stable/external-dns` README. Add `aws.batchChangeSize=400` to combat messages about RDATA being too large. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64356
Diffstat (limited to 'scripts/review_apps/review-apps.sh')
-rwxr-xr-xscripts/review_apps/review-apps.sh7
1 files changed, 4 insertions, 3 deletions
diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh
index 2bf654b1e24..bc47884ee45 100755
--- a/scripts/review_apps/review-apps.sh
+++ b/scripts/review_apps/review-apps.sh
@@ -132,13 +132,14 @@ function install_external_dns() {
echoinfo "Installing external-dns Helm chart"
helm repo update
# Default requested: CPU => 0, memory => 0
- helm install stable/external-dns \
+ helm install stable/external-dns --version '^2.2.1' \
-n "${release_name}" \
--namespace "${KUBE_NAMESPACE}" \
--set provider="aws" \
- --set aws.secretKey="${REVIEW_APPS_AWS_SECRET_KEY}" \
- --set aws.accessKey="${REVIEW_APPS_AWS_ACCESS_KEY}" \
+ --set aws.credentials.secretKey="${REVIEW_APPS_AWS_SECRET_KEY}" \
+ --set aws.credentials.accessKey="${REVIEW_APPS_AWS_ACCESS_KEY}" \
--set aws.zoneType="public" \
+ --set aws.batchChangeSize=400 \
--set domainFilters[0]="${domain}" \
--set txtOwnerId="${KUBE_NAMESPACE}" \
--set rbac.create="true" \