Merge remote-tracking branch 'upstream/master' into no-ivar-in-modules

* upstream/master: (1723 commits)
  Resolve "Editor icons"
  Refactor issuable destroy action
  Ignore routes matching legacy_*_redirect in route specs
  Gitlab::Git::RevList and LfsChanges use lazy popen
  Gitlab::Git::Popen can lazily hand output to a block
  Merge branch 'master-i18n' into 'master'
  Remove unique validation from external_url in Environment
  Expose `duration` in Job API entity
  Add TimeCop freeze for DST and Regular time
  Harcode project visibility
  update a changelog
  Put a condition to old migration that adds fast_forward column to MRs
  Expose project visibility as CI variable
  fix flaky tests by removing unneeded clicks and focus actions
  fix flaky test in gfm_autocomplete_spec.rb
  Use Gitlab::Git operations for repository mirroring
  Encapsulate git operations for mirroring in Gitlab::Git
  Create a Wiki Repository's raw_repository properly
  Add `Gitlab::Git::Repository#fetch` command
  Fix Gitlab::Metrics::System#real_time and #monotonic_time doc
  ...

1 files changed, 18 insertions, 8 deletions

diff --git a/scripts/static-analysis b/scripts/static-analysis
index 295b6f132c1..51a2fd81a79 100755
--- a/scripts/static-analysis
+++ b/scripts/static-analysis
@@ -11,30 +11,40 @@ tasks = [
   %w[bundle exec rake brakeman],
   %w[bundle exec license_finder],
   %w[yarn run eslint],
-  %w[bundle exec rubocop --require rubocop-rspec],
+  %w[bundle exec rubocop --parallel],
   %w[scripts/lint-conflicts.sh],
-  %w[bundle exec rake gettext:lint]
+  %w[bundle exec rake gettext:lint],
+  %w[scripts/lint-changelog-yaml]
 ]
 
 failed_tasks = tasks.reduce({}) do |failures, task|
-  output, status = Gitlab::Popen.popen(task)
+  start = Time.now
+  puts
+  puts "$ #{task.join(' ')}"
 
-  puts "Running: #{task.join(' ')}"
-  puts output
+  output, status = Gitlab::Popen.popen(task)
+  puts "==> Finished in #{Time.now - start} seconds"
+  puts
 
   failures[task.join(' ')] = output unless status.zero?
 
   failures
 end
 
+puts
+puts '==================================================='
+puts
+puts
+
 if failed_tasks.empty?
   puts 'All static analyses passed successfully.'
 else
-  puts "\n===================================================\n\n"
-  puts "Some static analyses failed:"
+  puts 'Some static analyses failed:'
 
   failed_tasks.each do |failed_task, output|
-    puts "\n**** #{failed_task} failed with the following error:\n\n"
+    puts
+    puts "**** #{failed_task} failed with the following error:"
+    puts
     puts output
   end