summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2018-11-09 12:30:49 +0100
committerRémy Coutable <remy@rymai.me>2018-11-09 12:30:51 +0100
commitf7f42cf34553f93c875186f61efc5909d0099cd4 (patch)
tree4d280faa50101c256f1cab4c9694f38871a00f6b /scripts
parentef58a64039c517be7df08eef1b3a7af7ad5eab16 (diff)
downloadgitlab-ce-f7f42cf34553f93c875186f61efc5909d0099cd4.tar.gz
Ensure we create the secrets at the right time53621-review-app-credentials-does-not-reliably-work
In `deploy`, if the previous deployment failed, we delete/cleanup all the objects related to the release, including secrets. The problem is that if we create the root password before that, it will be then recreated during the deploy with a random value! By creatigng the secret just before actually deplying a new release, we ensure that it won't be overriden. Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'scripts')
-rwxr-xr-xscripts/review_apps/review-apps.sh3
1 files changed, 3 insertions, 0 deletions
diff --git a/scripts/review_apps/review-apps.sh b/scripts/review_apps/review-apps.sh
index d372bcbdab1..016682e5a3d 100755
--- a/scripts/review_apps/review-apps.sh
+++ b/scripts/review_apps/review-apps.sh
@@ -126,6 +126,9 @@ function deploy() {
delete
cleanup
fi
+
+ create_secret
+
helm repo add gitlab https://charts.gitlab.io/
helm dep update .