diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2016-09-23 12:54:23 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2016-09-23 12:54:23 +0000 |
commit | d114a5224815049bb680ead66b2a228f0000b669 (patch) | |
tree | 7347a5230fdf68131bff147354fc7a7ece959dd2 /shared | |
parent | 2a772b7d838a3567ffe707ac59b7b53320573d5f (diff) | |
parent | d4de3ca079960e348cb733746746065bcd8c3608 (diff) | |
download | gitlab-ce-d114a5224815049bb680ead66b2a228f0000b669.tar.gz |
Merge branch 'cycle-analytics-js-improvements' into 'master'
Fix Cycle Analytics landing widget state and improve state management in Vue.
## What does this MR do?
- Fixes Cycle Analytics help widget show/hide issue
- Addresses initial MR feedback with improving Vue state management logic
- Fixes cookie path of the help widget so when you close a help widget in a repo it won't be visible for other repos.
## Are there points in the code the reviewer needs to double check?
- Should we move `gl.cycleAnalyticsModel` to a new file.
## Why was this MR needed?
- Addresses feedbacks of [initial MR](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5986) and fixes #22483
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
## What are the relevant issue numbers?
Fixes #22483
See merge request !6492
Diffstat (limited to 'shared')
0 files changed, 0 insertions, 0 deletions