diff options
author | Luke Duncalfe <lduncalfe@eml.cc> | 2019-07-09 13:58:57 +1200 |
---|---|---|
committer | Luke Duncalfe <lduncalfe@eml.cc> | 2019-08-21 11:39:41 +1200 |
commit | 926bf71e511e084fa033b4e96f5b4067e0eeca0a (patch) | |
tree | a9015ce749112eba53fdba3bb3bba145615942e4 /spec/controllers/projects/notes_controller_spec.rb | |
parent | 15b02da69f1b3bfac859d076728a46586b53db6b (diff) | |
download | gitlab-ce-926bf71e511e084fa033b4e96f5b4067e0eeca0a.tar.gz |
Improve specs for Issues and Notes controllers63372-award-emoji-services
This adds test that Todos are completed.
https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
Diffstat (limited to 'spec/controllers/projects/notes_controller_spec.rb')
-rw-r--r-- | spec/controllers/projects/notes_controller_spec.rb | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/spec/controllers/projects/notes_controller_spec.rb b/spec/controllers/projects/notes_controller_spec.rb index 9ab565dc2e8..4500c412521 100644 --- a/spec/controllers/projects/notes_controller_spec.rb +++ b/spec/controllers/projects/notes_controller_spec.rb @@ -543,23 +543,32 @@ describe Projects::NotesController do project.add_developer(user) end + subject { post(:toggle_award_emoji, params: request_params.merge(name: emoji_name)) } + let(:emoji_name) { 'thumbsup' } + it "toggles the award emoji" do expect do - post(:toggle_award_emoji, params: request_params.merge(name: "thumbsup")) + subject end.to change { note.award_emoji.count }.by(1) expect(response).to have_gitlab_http_status(200) end it "removes the already awarded emoji" do - post(:toggle_award_emoji, params: request_params.merge(name: "thumbsup")) + create(:award_emoji, awardable: note, name: emoji_name, user: user) - expect do - post(:toggle_award_emoji, params: request_params.merge(name: "thumbsup")) - end.to change { AwardEmoji.count }.by(-1) + expect { subject }.to change { AwardEmoji.count }.by(-1) expect(response).to have_gitlab_http_status(200) end + + it 'marks Todos on the Noteable as done' do + todo = create(:todo, target: note.noteable, project: project, user: user) + + subject + + expect(todo.reload).to be_done + end end describe "resolving and unresolving" do |