summaryrefslogtreecommitdiff
path: root/spec/controllers/snippets/notes_controller_spec.rb
diff options
context:
space:
mode:
authorPeter Leitzen <pleitzen@gitlab.com>2019-07-16 08:03:49 +0000
committerGrzegorz Bizon <grzegorz@gitlab.com>2019-07-16 08:03:49 +0000
commit7b87ed14991737930eb8f353feec9e6c8af6c1ac (patch)
treea5c22c297184ed7b00156d3a9a7f3edf19c19a41 /spec/controllers/snippets/notes_controller_spec.rb
parente38a3bba1b32754a11e805093f306135beee55dd (diff)
downloadgitlab-ce-7b87ed14991737930eb8f353feec9e6c8af6c1ac.tar.gz
Cleanup usages of `JSON.parse` in specs
Prefer `json_response` where applicable.
Diffstat (limited to 'spec/controllers/snippets/notes_controller_spec.rb')
-rw-r--r--spec/controllers/snippets/notes_controller_spec.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/spec/controllers/snippets/notes_controller_spec.rb b/spec/controllers/snippets/notes_controller_spec.rb
index 586d59c2d09..652533ac49f 100644
--- a/spec/controllers/snippets/notes_controller_spec.rb
+++ b/spec/controllers/snippets/notes_controller_spec.rb
@@ -26,7 +26,7 @@ describe Snippets::NotesController do
end
it "returns not empty array of notes" do
- expect(JSON.parse(response.body)["notes"].empty?).to be_falsey
+ expect(json_response["notes"].empty?).to be_falsey
end
end
@@ -97,7 +97,7 @@ describe Snippets::NotesController do
it "returns 1 note" do
get :index, params: { snippet_id: private_snippet }
- expect(JSON.parse(response.body)['notes'].count).to eq(1)
+ expect(json_response['notes'].count).to eq(1)
end
end
end
@@ -114,7 +114,7 @@ describe Snippets::NotesController do
it "does not return any note" do
get :index, params: { snippet_id: public_snippet }
- expect(JSON.parse(response.body)['notes'].count).to eq(0)
+ expect(json_response['notes'].count).to eq(0)
end
end
end