diff options
author | Matija Čupić <matteeyah@gmail.com> | 2017-12-01 15:57:43 +0100 |
---|---|---|
committer | Matija Čupić <matteeyah@gmail.com> | 2017-12-01 16:04:42 +0100 |
commit | f6057437dc052431b2fc0485f837931ba0b5044d (patch) | |
tree | 32b7541684dfa5193730c86461bf8cba6e6342fc /spec/controllers | |
parent | 42d87f90859087af34f27dd926576243ead876ce (diff) | |
download | gitlab-ce-f6057437dc052431b2fc0485f837931ba0b5044d.tar.gz |
Rename spec local variable to avoid shadowing
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/projects/clusters_controller_spec.rb | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/spec/controllers/projects/clusters_controller_spec.rb b/spec/controllers/projects/clusters_controller_spec.rb index 8db0395cecb..3d63d5c4394 100644 --- a/spec/controllers/projects/clusters_controller_spec.rb +++ b/spec/controllers/projects/clusters_controller_spec.rb @@ -16,10 +16,7 @@ describe Projects::ClustersController do context 'when project has one or more clusters' do let(:project) { create(:project) } let(:clusters) { create_list(:cluster, 2, :provided_by_gcp, projects: [project]) } - - before do - clusters.last.enabled = false - end + let(:inactive_cluster) { create(:cluster, :provided_by_gcp, projects: [project]) } it 'lists available clusters' do go @@ -56,16 +53,16 @@ describe Projects::ClustersController do context 'when only enabled clusters are requested' do it 'returns only enabled clusters' do get :index, namespace_id: project.namespace, project_id: project, scope: 'active' - clusters = assigns(:clusters) - expect(clusters.all? { |cluster| cluster.enabled == true }).to eq(true) + view_clusters = assigns(:clusters) + expect(view_clusters.all? { |cluster| cluster.enabled == true }).to eq(true) end end context 'when only disabled clusters are requested' do it 'returns only disabled clusters' do get :index, namespace_id: project.namespace, project_id: project, scope: 'inactive' - clusters = assigns(:clusters) - expect(clusters.all? { |cluster| cluster.enabled == false }).to eq(true) + view_clusters = assigns(:clusters) + expect(view_clusters.all? { |cluster| cluster.enabled == false }).to eq(true) end end end |