diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-29 12:58:00 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2021-09-29 12:58:00 +0000 |
commit | a3adc9bca8f340d1e88fda2e5c5d24326417acc4 (patch) | |
tree | 21066363dbdfe79fd6fb6ea2f80578227b449108 /spec/controllers | |
parent | e0ab280b774e34fcfd6fd031616247714230ca68 (diff) | |
download | gitlab-ce-a3adc9bca8f340d1e88fda2e5c5d24326417acc4.tar.gz |
Add latest changes from gitlab-org/security/gitlab@14-3-stable-ee
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/admin/impersonations_controller_spec.rb | 8 | ||||
-rw-r--r-- | spec/controllers/admin/users_controller_spec.rb | 8 |
2 files changed, 16 insertions, 0 deletions
diff --git a/spec/controllers/admin/impersonations_controller_spec.rb b/spec/controllers/admin/impersonations_controller_spec.rb index 744c0712d6b..ccf4454c349 100644 --- a/spec/controllers/admin/impersonations_controller_spec.rb +++ b/spec/controllers/admin/impersonations_controller_spec.rb @@ -92,6 +92,14 @@ RSpec.describe Admin::ImpersonationsController do expect(warden.user).to eq(impersonator) end + + it 'clears token session keys' do + session[:bitbucket_token] = SecureRandom.hex(8) + + delete :destroy + + expect(session[:bitbucket_token]).to be_nil + end end # base case diff --git a/spec/controllers/admin/users_controller_spec.rb b/spec/controllers/admin/users_controller_spec.rb index e43ba6358f9..3a2b5dcb99d 100644 --- a/spec/controllers/admin/users_controller_spec.rb +++ b/spec/controllers/admin/users_controller_spec.rb @@ -794,6 +794,14 @@ RSpec.describe Admin::UsersController do expect(flash[:alert]).to eq("You are now impersonating #{user.username}") end + + it 'clears token session keys' do + session[:github_access_token] = SecureRandom.hex(8) + + post :impersonate, params: { id: user.username } + + expect(session[:github_access_token]).to be_nil + end end context "when impersonation is disabled" do |