summaryrefslogtreecommitdiff
path: root/spec/controllers
diff options
context:
space:
mode:
authorLukas '+ alert('Eipi') + ' Eipert <leipert@gitlab.com>2019-08-02 14:38:50 +0000
committerFatih Acet <acetfatih@gmail.com>2019-08-02 14:38:50 +0000
commitfc9f099884f6b98dea3f4e6110ecba6151fa75b8 (patch)
tree037c50677bea22d8e0b1733f210e08de01e32962 /spec/controllers
parent0fec9a4fc7fae7480a92d6402d3ad144b4bd7233 (diff)
downloadgitlab-ce-fc9f099884f6b98dea3f4e6110ecba6151fa75b8.tar.gz
Prevent empty classes in ansi2html conversion
Currently we write out empty CSS classes (`class=""`) every time we create a new tag. This adds 9 unnecessary bytes per span element. In a recent trace, I have counted 11950 span elements. So we transported 105 unnecessary kilobytes!
Diffstat (limited to 'spec/controllers')
-rw-r--r--spec/controllers/projects/jobs_controller_spec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/controllers/projects/jobs_controller_spec.rb b/spec/controllers/projects/jobs_controller_spec.rb
index 39ebf02dcf5..f076a5e769f 100644
--- a/spec/controllers/projects/jobs_controller_spec.rb
+++ b/spec/controllers/projects/jobs_controller_spec.rb
@@ -546,7 +546,7 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
expect(response).to have_gitlab_http_status(:ok)
expect(json_response['id']).to eq job.id
expect(json_response['status']).to eq job.status
- expect(json_response['html']).to eq('<span class="">BUILD TRACE</span>')
+ expect(json_response['html']).to eq('<span>BUILD TRACE</span>')
end
end