diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-08-20 18:12:28 +0000 |
|---|---|---|
| committer | Mayra Cabrera <mcabrera@gitlab.com> | 2019-08-20 18:12:28 +0000 |
| commit | e632ae80845f849f93e4d85ef9f836a4792844c9 (patch) | |
| tree | 5715c29c7a6b6ed93e16f8ab0f59b229af3ba646 /spec/controllers | |
| parent | a493cccdda6d2ab0fd21e60a144504a6cf6747ee (diff) | |
| download | gitlab-ce-e632ae80845f849f93e4d85ef9f836a4792844c9.tar.gz | |
Standardize remote_ip and path keys for auth.log and api_json.log
Current `auth.log` uses `fullpath` and `ip`, while `api_json.log` uses
`remote_ip` and `path` for the same fields. Let's standardize these
namings to make it easier for people working with the data.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66167
Diffstat (limited to 'spec/controllers')
| -rw-r--r-- | spec/controllers/projects/raw_controller_spec.rb | 4 | ||||
| -rw-r--r-- | spec/controllers/registrations_controller_spec.rb | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/spec/controllers/projects/raw_controller_spec.rb b/spec/controllers/projects/raw_controller_spec.rb index b958f419a19..8b43d1264b2 100644 --- a/spec/controllers/projects/raw_controller_spec.rb +++ b/spec/controllers/projects/raw_controller_spec.rb @@ -67,9 +67,9 @@ describe Projects::RawController do attributes = { message: 'Action_Rate_Limiter_Request', env: :raw_blob_request_limit, - ip: '0.0.0.0', + remote_ip: '0.0.0.0', request_method: 'GET', - fullpath: "/#{project.full_path}/raw/#{file_path}" + path: "/#{project.full_path}/raw/#{file_path}" } expect(Gitlab::AuthLogger).to receive(:error).with(attributes).once diff --git a/spec/controllers/registrations_controller_spec.rb b/spec/controllers/registrations_controller_spec.rb index fed4fc810f2..35487682462 100644 --- a/spec/controllers/registrations_controller_spec.rb +++ b/spec/controllers/registrations_controller_spec.rb @@ -129,9 +129,9 @@ describe RegistrationsController do { message: auth_log_message, env: :invisible_captcha_signup_bot_detected, - ip: '0.0.0.0', + remote_ip: '0.0.0.0', request_method: 'POST', - fullpath: '/users' + path: '/users' } end |