diff options
| author | Stan Hu <stanhu@gmail.com> | 2015-09-18 08:39:19 -0700 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2015-09-21 07:00:55 -0700 |
| commit | ea5c25bb4ed46decde33c86e618f0b18dd55dae3 (patch) | |
| tree | d89f757d60ca9a599405d83c51f126f7d30ca4f0 /spec/controllers | |
| parent | abaa65efc1f912ffef05ccaf1e92dc009f828278 (diff) | |
| download | gitlab-ce-ea5c25bb4ed46decde33c86e618f0b18dd55dae3.tar.gz | |
Remove milestones from merge requests when milestones are deleted
Reported by https://github.com/gitlabhq/gitlabhq/issues/9643
Diffstat (limited to 'spec/controllers')
| -rw-r--r-- | spec/controllers/projects/milestones_controller_spec.rb | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/spec/controllers/projects/milestones_controller_spec.rb b/spec/controllers/projects/milestones_controller_spec.rb index 35446640929..8127efabe6e 100644 --- a/spec/controllers/projects/milestones_controller_spec.rb +++ b/spec/controllers/projects/milestones_controller_spec.rb @@ -5,6 +5,7 @@ describe Projects::MilestonesController do let(:user) { create(:user) } let(:milestone) { create(:milestone, project: project) } let(:issue) { create(:issue, project: project, milestone: milestone) } + let(:merge_request) { create(:merge_request, source_project: project, target_project: project, milestone: milestone) } before do sign_in(user) @@ -14,6 +15,7 @@ describe Projects::MilestonesController do describe "#destroy" do it "should remove milestone" do + merge_request.reload expect(issue.milestone_id).to eq(milestone.id) delete :destroy, namespace_id: project.namespace.id, project_id: project.id, id: milestone.id, format: :js @@ -24,6 +26,10 @@ describe Projects::MilestonesController do expect { Milestone.find(milestone.id) }.to raise_exception(ActiveRecord::RecordNotFound) issue.reload expect(issue.milestone_id).to eq(nil) + + merge_request.reload + expect(merge_request.milestone_id).to eq(nil) + # Check system note left for milestone removal last_note = project.issues.find(issue.id).notes[-1].note expect(last_note).to eq('Milestone removed') |
