summaryrefslogtreecommitdiff
path: root/spec/controllers
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2017-07-04 01:51:21 +0900
committerShinya Maeda <shinya@gitlab.com>2017-07-05 18:36:19 +0900
commitbbbd5521d2d177561efd6f8171394abef6ec90ff (patch)
tree1ee3957e02bc5d06cc68c97a0b6f6a13003b5836 /spec/controllers
parent17f34e5a74cdfbf37e45b3db603cffb8035c8db4 (diff)
downloadgitlab-ce-bbbd5521d2d177561efd6f8171394abef6ec90ff.tar.gz
Improve spec
Diffstat (limited to 'spec/controllers')
-rw-r--r--spec/controllers/projects/pipeline_schedules_controller_spec.rb19
1 files changed, 9 insertions, 10 deletions
diff --git a/spec/controllers/projects/pipeline_schedules_controller_spec.rb b/spec/controllers/projects/pipeline_schedules_controller_spec.rb
index 12eeca5408b..be6a758bb4d 100644
--- a/spec/controllers/projects/pipeline_schedules_controller_spec.rb
+++ b/spec/controllers/projects/pipeline_schedules_controller_spec.rb
@@ -47,11 +47,11 @@ describe Projects::PipelineSchedulesController do
end
describe 'GET #new' do
+ set(:user) { create(:user) }
+
before do
- create(:user).tap do |user|
- project.add_developer(user)
- sign_in(user)
- end
+ project.add_developer(user)
+ sign_in(user)
end
it 'initializes a pipeline schedule model' do
@@ -64,11 +64,11 @@ describe Projects::PipelineSchedulesController do
describe 'POST #create' do
describe 'functionality' do
+ set(:user) { create(:user) }
+
before do
- create(:user).tap do |user|
- project.add_developer(user)
- sign_in(user)
- end
+ project.add_developer(user)
+ sign_in(user)
end
let(:basic_param) do
@@ -188,7 +188,7 @@ describe Projects::PipelineSchedulesController do
describe 'PUT #update' do
describe 'functionality' do
- let(:user) { create(:user) }
+ set(:user) { create(:user) }
let!(:pipeline_schedule) { create(:ci_pipeline_schedule, project: project, owner: user) }
before do
@@ -397,7 +397,6 @@ describe Projects::PipelineSchedulesController do
before do
project.add_master(user)
-
sign_in(user)
end