diff options
| author | Sean McGivern <sean@gitlab.com> | 2018-11-29 12:52:48 +0000 |
|---|---|---|
| committer | Sean McGivern <sean@gitlab.com> | 2018-11-30 11:57:56 +0000 |
| commit | 7fd5dbf9db4e513faaabbe14aff3c10fca603415 (patch) | |
| tree | de44c17a53b286b8230260cab6c499e85cc4cbb8 /spec/controllers | |
| parent | 938b891f89403ced0268699a6295531db508be17 (diff) | |
| download | gitlab-ce-7fd5dbf9db4e513faaabbe14aff3c10fca603415.tar.gz | |
Add a flag to use a subquery for group issues search
We already had a flag to use a CTE, but this broke searching in some
cases where we need to sort by a joined table. Disabling the CTE flag
makes searches much slower.
The new flag, to use a subquery, makes them slightly slower than the
CTE, while maintaining correctness. If both it and the CTE flag are
enabled, the subquery takes precedence.
Diffstat (limited to 'spec/controllers')
| -rw-r--r-- | spec/controllers/groups_controller_spec.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb index f6c85102830..4b0dc4c9b69 100644 --- a/spec/controllers/groups_controller_spec.rb +++ b/spec/controllers/groups_controller_spec.rb @@ -226,9 +226,10 @@ describe GroupsController do end context 'searching' do - # Remove as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/52271 before do + # Remove in https://gitlab.com/gitlab-org/gitlab-ce/issues/54643 stub_feature_flags(use_cte_for_group_issues_search: false) + stub_feature_flags(use_subquery_for_group_issues_search: true) end it 'works with popularity sort' do |