diff options
author | Camil Staps <info@camilstaps.nl> | 2019-07-27 08:26:53 +0200 |
---|---|---|
committer | Camil Staps <info@camilstaps.nl> | 2019-08-07 20:49:37 +0200 |
commit | d4078b535c9854695e770cdfb5e0f4846a8cf64a (patch) | |
tree | d018c433af17263a419c41473e589f4e9e28ca38 /spec/controllers | |
parent | e726ed5e128893158f102b87e1407ec0a36fc3ce (diff) | |
download | gitlab-ce-d4078b535c9854695e770cdfb5e0f4846a8cf64a.tar.gz |
Fix public/private starrers counts in special cases20137-starrers
Diffstat (limited to 'spec/controllers')
-rw-r--r-- | spec/controllers/projects/starrers_controller_spec.rb | 43 |
1 files changed, 38 insertions, 5 deletions
diff --git a/spec/controllers/projects/starrers_controller_spec.rb b/spec/controllers/projects/starrers_controller_spec.rb index 863929a2465..59d258e99ce 100644 --- a/spec/controllers/projects/starrers_controller_spec.rb +++ b/spec/controllers/projects/starrers_controller_spec.rb @@ -5,6 +5,7 @@ require 'spec_helper' describe Projects::StarrersController do let(:user) { create(:user) } let(:private_user) { create(:user, private_profile: true) } + let(:admin) { create(:user, admin: true) } let(:project) { create(:project, :public, :repository) } before do @@ -26,25 +27,57 @@ describe Projects::StarrersController do project.update_attribute(:visibility_level, Project::PUBLIC) end - it 'only public starrers are visible for non logged in users' do - get_starrers + context 'when no user is logged in' do + before do + get_starrers + end - user_ids = assigns[:starrers].map { |s| s['user_id'] } - expect(user_ids).to include(user.id) - expect(user_ids).not_to include(private_user.id) + it 'only public starrers are visible' do + user_ids = assigns[:starrers].map { |s| s['user_id'] } + expect(user_ids).to include(user.id) + expect(user_ids).not_to include(private_user.id) + end + + it 'public/private starrers counts are correct' do + expect(assigns[:public_count]).to eq(1) + expect(assigns[:private_count]).to eq(1) + end end context 'when private user is logged in' do before do sign_in(private_user) + + get_starrers end it 'their star is also visible' do + user_ids = assigns[:starrers].map { |s| s['user_id'] } + expect(user_ids).to include(user.id, private_user.id) + end + + it 'public/private starrers counts are correct' do + expect(assigns[:public_count]).to eq(1) + expect(assigns[:private_count]).to eq(1) + end + end + + context 'when admin is logged in' do + before do + sign_in(admin) + get_starrers + end + it 'all stars are visible' do user_ids = assigns[:starrers].map { |s| s['user_id'] } expect(user_ids).to include(user.id, private_user.id) end + + it 'public/private starrers counts are correct' do + expect(assigns[:public_count]).to eq(1) + expect(assigns[:private_count]).to eq(1) + end end end |