summaryrefslogtreecommitdiff
path: root/spec/controllers
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2018-05-07 18:22:07 +0200
committerYorick Peterse <yorickpeterse@gmail.com>2018-05-17 13:53:00 +0200
commit19428e800895ba20eacb3357285acef8d69f6d8c (patch)
tree0f16e630b6a808b6013d463146c32a134d6ee9c0 /spec/controllers
parent70985aa19b389c2ee8234edfbb516b5403a7bfcf (diff)
downloadgitlab-ce-19428e800895ba20eacb3357285acef8d69f6d8c.tar.gz
Preload pipeline data for project pipelines
When displaying the pipelines of a project we now preload the following data: 1. Authors of the commits that belong to these pipelines 2. The number of warnings per pipeline, which is used by Ci::Pipeline#has_warnings? == Commit Authors Previously this data was queried for every Commit separately, leading to 20 SQL queries being executed in the worst case. With an average of 3 to 5 milliseconds per SQL query this could result in 100 milliseconds being spent in _just_ getting Commit authors. To preload this data Commit#author now uses BatchLoader (through Commit#lazy_author), and a separate module Gitlab::Ci::Pipeline::Preloader is used to ensure all authors are loaded before they are used. == Number of warnings This changes Ci::Pipeline#has_warnings? so it supports preloading of the number of warnings per pipeline. This removes the need for executing a COUNT(*) query for every pipeline just to see if it has any warnings or not.
Diffstat (limited to 'spec/controllers')
0 files changed, 0 insertions, 0 deletions