diff options
author | Constance Okoghenun <cokoghenun@gitlab.com> | 2019-01-24 14:41:42 +0000 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2019-01-31 16:52:49 +0100 |
commit | 645f7ee86b138de29245264fea32057bb6060a93 (patch) | |
tree | 1b49d420a6c161ed5de190caf5ef407b6db18913 /spec/features/markdown | |
parent | 77528641256e4728f76541ab294c397447ba169e (diff) | |
download | gitlab-ce-645f7ee86b138de29245264fea32057bb6060a93.tar.gz |
[master] Resolve "[Security] Stored XSS via KaTeX"
Diffstat (limited to 'spec/features/markdown')
-rw-r--r-- | spec/features/markdown/math_spec.rb | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/spec/features/markdown/math_spec.rb b/spec/features/markdown/math_spec.rb index 678ce80b382..53abb5e3722 100644 --- a/spec/features/markdown/math_spec.rb +++ b/spec/features/markdown/math_spec.rb @@ -1,6 +1,8 @@ require 'spec_helper' describe 'Math rendering', :js do + let!(:project) { create(:project, :public) } + it 'renders inline and display math correctly' do description = <<~MATH This math is inline $`a^2+b^2=c^2`$. @@ -11,7 +13,6 @@ describe 'Math rendering', :js do ``` MATH - project = create(:project, :public) issue = create(:issue, project: project, description: description) visit project_issue_path(project, issue) @@ -19,4 +20,19 @@ describe 'Math rendering', :js do expect(page).to have_selector('.katex .mord.mathdefault', text: 'b') expect(page).to have_selector('.katex-display .mord.mathdefault', text: 'b') end + + it 'only renders non XSS links' do + description = <<~MATH + This link is valid $`\\href{javascript:alert('xss');}{xss}`$. + + This link is valid $`\\href{https://gitlab.com}{Gitlab}`$. + MATH + + issue = create(:issue, project: project, description: description) + + visit project_issue_path(project, issue) + + expect(page).to have_selector('.katex-error', text: "\href{javascript:alert('xss');}{xss}") + expect(page).to have_selector('.katex-html a', text: 'Gitlab') + end end |