diff options
author | Rémy Coutable <remy@rymai.me> | 2016-09-29 16:55:55 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-09-29 16:57:17 +0200 |
commit | f3c456eda691a19b9cf1cb274901d43d15f109dc (patch) | |
tree | c28065d196d9679d7a518028eb0e3cb7b5d2b0e9 /spec/features/merge_requests/filter_by_milestone_spec.rb | |
parent | f525344a6a9458c9c2c0e1936800c16de1d80914 (diff) | |
download | gitlab-ce-f3c456eda691a19b9cf1cb274901d43d15f109dc.tar.gz |
Small improvements thanks to Robert's feedback15356-filters-should-change-issue-counts
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/features/merge_requests/filter_by_milestone_spec.rb')
-rw-r--r-- | spec/features/merge_requests/filter_by_milestone_spec.rb | 18 |
1 files changed, 3 insertions, 15 deletions
diff --git a/spec/features/merge_requests/filter_by_milestone_spec.rb b/spec/features/merge_requests/filter_by_milestone_spec.rb index 3d5d9614fb6..d917d5950ec 100644 --- a/spec/features/merge_requests/filter_by_milestone_spec.rb +++ b/spec/features/merge_requests/filter_by_milestone_spec.rb @@ -17,11 +17,7 @@ feature 'Merge Request filtering by Milestone', feature: true do visit_merge_requests(project) filter_by_milestone(Milestone::None.title) - page.within '.issues-state-filters' do - expect(page).to have_content('Open 1') - expect(page).to have_content('Closed 0') - expect(page).to have_content('All 1') - end + expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1) expect(page).to have_css('.merge-request', count: 1) end @@ -44,11 +40,7 @@ feature 'Merge Request filtering by Milestone', feature: true do visit_merge_requests(project) filter_by_milestone(Milestone::Upcoming.title) - page.within '.issues-state-filters' do - expect(page).to have_content('Open 1') - expect(page).to have_content('Closed 0') - expect(page).to have_content('All 1') - end + expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1) expect(page).to have_css('.merge-request', count: 1) end @@ -71,11 +63,7 @@ feature 'Merge Request filtering by Milestone', feature: true do visit_merge_requests(project) filter_by_milestone(milestone.title) - page.within '.issues-state-filters' do - expect(page).to have_content('Open 1') - expect(page).to have_content('Closed 0') - expect(page).to have_content('All 1') - end + expect(page).to have_issuable_counts(open: 1, closed: 0, all: 1) expect(page).to have_css('.merge-request', count: 1) end |