Address review feedback

Signed-off-by: Rémy Coutable <remy@rymai.me>

1 files changed, 9 insertions, 15 deletions

diff --git a/spec/features/projects/files/download_buttons_spec.rb b/spec/features/projects/files/download_buttons_spec.rb
index 8c9252baf15..03cb3530e2b 100644
--- a/spec/features/projects/files/download_buttons_spec.rb
+++ b/spec/features/projects/files/download_buttons_spec.rb
@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe 'Projects > Files > Download buttons in files tree' do
-  let(:user) { create(:user) }
-  let(:role) { :developer }
-  let(:status) { 'success' }
   let(:project) { create(:project, :repository) }
+  let(:user) { project.creator }
 
   let(:pipeline) do
     create(:ci_pipeline,
            project: project,
            sha: project.commit.sha,
            ref: project.default_branch,
-           status: status)
+           status: 'success')
   end
 
   let!(:build) do
@@ -23,20 +21,16 @@ describe 'Projects > Files > Download buttons in files tree' do
 
   before do
     sign_in(user)
-    project.add_role(user, role)
-  end
+    project.add_developer(user)
 
-  describe 'when files tree' do
-    context 'with artifacts' do
-      before do
-        visit project_tree_path(project, project.default_branch)
-      end
+    visit project_tree_path(project, project.default_branch)
+  end
 
-      it 'shows download artifacts button' do
-        href = latest_succeeded_project_artifacts_path(project, "#{project.default_branch}/download", job: 'build')
+  context 'with artifacts' do
+    it 'shows download artifacts button' do
+      href = latest_succeeded_project_artifacts_path(project, "#{project.default_branch}/download", job: 'build')
 
-        expect(page).to have_link "Download '#{build.name}'", href: href
-      end
+      expect(page).to have_link "Download '#{build.name}'", href: href
     end
   end
 end