summaryrefslogtreecommitdiff
path: root/spec/features/security
diff options
context:
space:
mode:
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2014-02-25 17:14:03 +0200
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>2014-02-25 17:14:03 +0200
commitf7ca46b5a3bf4e74f432de8a4adfd2ebbb2e3bc5 (patch)
treec6dfea854c66d9398b10b32146e9ab895f3f2917 /spec/features/security
parent6304428467319d5598ec4773aeab39ccecf089cb (diff)
downloadgitlab-ce-f7ca46b5a3bf4e74f432de8a4adfd2ebbb2e3bc5.tar.gz
Dont test models methods in security specs
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Diffstat (limited to 'spec/features/security')
-rw-r--r--spec/features/security/group/group_access_spec.rb5
-rw-r--r--spec/features/security/group/internal_group_access_spec.rb7
-rw-r--r--spec/features/security/group/mixed_group_access_spec.rb5
-rw-r--r--spec/features/security/group/public_group_access_spec.rb7
4 files changed, 2 insertions, 22 deletions
diff --git a/spec/features/security/group/group_access_spec.rb b/spec/features/security/group/group_access_spec.rb
index 7ef372c9199..c262d76ab54 100644
--- a/spec/features/security/group/group_access_spec.rb
+++ b/spec/features/security/group/group_access_spec.rb
@@ -22,11 +22,6 @@ describe "Group access" do
group.add_user(reporter, Gitlab::Access::REPORTER)
group.add_user(guest, Gitlab::Access::GUEST)
end
-
- describe "Group should not have accessible projects" do
- it { group.has_projects_accessible_to?(nil).should be_false }
- it { group.has_projects_accessible_to?(nonmember).should be_false }
- end
describe "GET /groups/:path" do
subject { group_path(group) }
diff --git a/spec/features/security/group/internal_group_access_spec.rb b/spec/features/security/group/internal_group_access_spec.rb
index 26b05b667a9..0c354f02456 100644
--- a/spec/features/security/group/internal_group_access_spec.rb
+++ b/spec/features/security/group/internal_group_access_spec.rb
@@ -15,14 +15,9 @@ describe "Group with internal project access" do
group.add_user(master, Gitlab::Access::MASTER)
group.add_user(reporter, Gitlab::Access::REPORTER)
group.add_user(guest, Gitlab::Access::GUEST)
-
+
create(:project, group: group, visibility_level: Gitlab::VisibilityLevel::INTERNAL)
end
-
- describe "Group should have accessible projects for users" do
- it { group.has_projects_accessible_to?(nil).should be_false }
- it { group.has_projects_accessible_to?(nonmember).should be_true }
- end
describe "GET /groups/:path" do
subject { group_path(group) }
diff --git a/spec/features/security/group/mixed_group_access_spec.rb b/spec/features/security/group/mixed_group_access_spec.rb
index 9cae49157a4..82e816e388a 100644
--- a/spec/features/security/group/mixed_group_access_spec.rb
+++ b/spec/features/security/group/mixed_group_access_spec.rb
@@ -19,11 +19,6 @@ describe "Group access" do
create(:project, path: "internal_project", group: group, visibility_level: Gitlab::VisibilityLevel::INTERNAL)
create(:project, path: "public_project", group: group, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
end
-
- describe "Group should have accessible projects" do
- it { group.has_projects_accessible_to?(nil).should be_true }
- it { group.has_projects_accessible_to?(nonmember).should be_true }
- end
describe "GET /groups/:path" do
subject { group_path(group) }
diff --git a/spec/features/security/group/public_group_access_spec.rb b/spec/features/security/group/public_group_access_spec.rb
index d64be437b7a..a9c0afbb60f 100644
--- a/spec/features/security/group/public_group_access_spec.rb
+++ b/spec/features/security/group/public_group_access_spec.rb
@@ -15,13 +15,8 @@ describe "Group with public project access" do
group.add_user(master, Gitlab::Access::MASTER)
group.add_user(reporter, Gitlab::Access::REPORTER)
group.add_user(guest, Gitlab::Access::GUEST)
-
- create(:project, group: group, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
- end
- describe "Group should have accessible projects" do
- it { group.has_projects_accessible_to?(nil).should be_true }
- it { group.has_projects_accessible_to?(nonmember).should be_true }
+ create(:project, group: group, visibility_level: Gitlab::VisibilityLevel::PUBLIC)
end
describe "GET /groups/:path" do