summaryrefslogtreecommitdiff
path: root/spec/features/tags
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2018-07-04 13:17:54 +0900
committerShinya Maeda <shinya@gitlab.com>2018-07-04 13:17:54 +0900
commitf11aa51eeaa7a8175a9075ba95038c675ef9a8a6 (patch)
tree922e35c954457ca50d4ed19e8cebe85656cec44a /spec/features/tags
parent93a964d449ad29e94e785209d7ecde217a8e9b25 (diff)
parent4c1a2a9b9977f68a05512ed1ff378ee0a2368aca (diff)
downloadgitlab-ce-f11aa51eeaa7a8175a9075ba95038c675ef9a8a6.tar.gz
Merge branch 'master' into build-chunks-on-object-storage
Diffstat (limited to 'spec/features/tags')
-rw-r--r--spec/features/tags/master_deletes_tag_spec.rb27
1 files changed, 6 insertions, 21 deletions
diff --git a/spec/features/tags/master_deletes_tag_spec.rb b/spec/features/tags/master_deletes_tag_spec.rb
index 9981bfa4609..1d4df2c55a7 100644
--- a/spec/features/tags/master_deletes_tag_spec.rb
+++ b/spec/features/tags/master_deletes_tag_spec.rb
@@ -35,30 +35,15 @@ feature 'Master deletes tag' do
end
context 'when pre-receive hook fails', :js do
- context 'when Gitaly operation_user_delete_tag feature is enabled' do
- before do
- allow_any_instance_of(Gitlab::GitalyClient::OperationService).to receive(:rm_tag)
- .and_raise(Gitlab::Git::PreReceiveError, 'Do not delete tags')
- end
-
- scenario 'shows the error message' do
- delete_first_tag
-
- expect(page).to have_content('Do not delete tags')
- end
+ before do
+ allow_any_instance_of(Gitlab::GitalyClient::OperationService).to receive(:rm_tag)
+ .and_raise(Gitlab::Git::PreReceiveError, 'Do not delete tags')
end
- context 'when Gitaly operation_user_delete_tag feature is disabled', :skip_gitaly_mock do
- before do
- allow_any_instance_of(Gitlab::Git::HooksService).to receive(:execute)
- .and_raise(Gitlab::Git::PreReceiveError, 'Do not delete tags')
- end
-
- scenario 'shows the error message' do
- delete_first_tag
+ scenario 'shows the error message' do
+ delete_first_tag
- expect(page).to have_content('Do not delete tags')
- end
+ expect(page).to have_content('Do not delete tags')
end
end