Resolve "Add new "Overview" tab on user profile page"

2 files changed, 125 insertions, 0 deletions

diff --git a/spec/features/users/overview_spec.rb b/spec/features/users/overview_spec.rb
new file mode 100644
index 00000000000..11f357cbaa5
--- /dev/null
+++ b/spec/features/users/overview_spec.rb
@@ -0,0 +1,123 @@
+require 'spec_helper'
+
+describe 'Overview tab on a user profile', :js do
+  let(:user) { create(:user) }
+  let(:contributed_project) { create(:project, :public, :repository) }
+
+  def push_code_contribution
+    event = create(:push_event, project: contributed_project, author: user)
+
+    create(:push_event_payload,
+           event: event,
+           commit_from: '11f9ac0a48b62cef25eedede4c1819964f08d5ce',
+           commit_to: '1cf19a015df3523caf0a1f9d40c98a267d6a2fc2',
+           commit_count: 3,
+           ref: 'master')
+  end
+
+  before do
+    sign_in user
+  end
+
+  describe 'activities section' do
+    shared_context 'visit overview tab' do
+      before do
+        visit user.username
+        page.find('.js-overview-tab a').click
+        wait_for_requests
+      end
+    end
+
+    describe 'user has no activities' do
+      include_context 'visit overview tab'
+
+      it 'does not show any entries in the list of activities' do
+        page.within('.activities-block') do
+          expect(page).not_to have_selector('.event-item')
+        end
+      end
+
+      it 'does not show a link to the activity list' do
+        expect(find('#js-overview .activities-block')).to have_selector('.js-view-all', visible: false)
+      end
+    end
+
+    describe 'user has 3 activities' do
+      before do
+        3.times { push_code_contribution }
+      end
+
+      include_context 'visit overview tab'
+
+      it 'display 3 entries in the list of activities' do
+        expect(find('#js-overview')).to have_selector('.event-item', count: 3)
+      end
+    end
+
+    describe 'user has 10 activities' do
+      before do
+        10.times { push_code_contribution }
+      end
+
+      include_context 'visit overview tab'
+
+      it 'displays 5 entries in the list of activities' do
+        expect(find('#js-overview')).to have_selector('.event-item', count: 5)
+      end
+
+      it 'shows a link to the activity list' do
+        expect(find('#js-overview .activities-block')).to have_selector('.js-view-all', visible: true)
+      end
+
+      it 'links to the activity tab' do
+        page.within('.activities-block') do
+          find('.js-view-all').click
+          wait_for_requests
+          expect(URI.parse(current_url).path).to eq("/users/#{user.username}/activity")
+        end
+      end
+    end
+  end
+
+  describe 'projects section' do
+    shared_context 'visit overview tab' do
+      before do
+        visit user.username
+        page.find('.js-overview-tab a').click
+        wait_for_requests
+      end
+    end
+
+    describe 'user has no personal projects' do
+      include_context 'visit overview tab'
+
+      it 'it shows an empty project list with an info message' do
+        page.within('.projects-block') do
+          expect(page).to have_content('No projects found')
+          expect(page).not_to have_selector('.project-row')
+        end
+      end
+
+      it 'does not show a link to the project list' do
+        expect(find('#js-overview .projects-block')).to have_selector('.js-view-all', visible: false)
+      end
+    end
+
+    describe 'user has a personal project' do
+      let(:private_project) { create(:project, :private, namespace: user.namespace, creator: user) { |p| p.add_maintainer(user) } }
+      let!(:private_event)   { create(:event, project: private_project, author: user) }
+
+      include_context 'visit overview tab'
+
+      it 'it shows one entry in the list of projects' do
+        page.within('.projects-block') do
+          expect(page).to have_selector('.project-row', count: 1)
+        end
+      end
+
+      it 'shows a link to the project list' do
+        expect(find('#js-overview .projects-block')).to have_selector('.js-view-all', visible: true)
+      end
+    end
+  end
+end
diff --git a/spec/features/users/show_spec.rb b/spec/features/users/show_spec.rb
index bc07ab48c39..86379164cf0 100644
--- a/spec/features/users/show_spec.rb
+++ b/spec/features/users/show_spec.rb
@@ -8,6 +8,7 @@ describe 'User page' do
       visit(user_path(user))
 
       page.within '.nav-links' do
+        expect(page).to have_link('Overview')
         expect(page).to have_link('Activity')
         expect(page).to have_link('Groups')
         expect(page).to have_link('Contributed projects')
@@ -44,6 +45,7 @@ describe 'User page' do
       visit(user_path(user))
 
       page.within '.nav-links' do
+        expect(page).to have_link('Overview')
         expect(page).to have_link('Activity')
         expect(page).to have_link('Groups')
         expect(page).to have_link('Contributed projects')