diff options
author | Douwe Maan <douwe@gitlab.com> | 2018-11-07 11:56:46 +0000 |
---|---|---|
committer | Douwe Maan <douwe@gitlab.com> | 2018-11-07 11:56:46 +0000 |
commit | a82a595728d54bdc12e51dfcfb22e9eddc449143 (patch) | |
tree | a21ee6f5abef214db8a134ea90736a0518593167 /spec/features | |
parent | e7df959b8f99875edd246c7ac7779c3203e8755e (diff) | |
parent | 9b53ba2a1577ae002af88f9443d09c9b6b20871c (diff) | |
download | gitlab-ce-a82a595728d54bdc12e51dfcfb22e9eddc449143.tar.gz |
Merge branch 'osw-comment-on-any-line-on-diffs' into 'master'
Comment on any expanded diff line on MRs
See merge request gitlab-org/gitlab-ce!22398
Diffstat (limited to 'spec/features')
-rw-r--r-- | spec/features/merge_request/user_posts_diff_notes_spec.rb | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/spec/features/merge_request/user_posts_diff_notes_spec.rb b/spec/features/merge_request/user_posts_diff_notes_spec.rb index fa148715855..51b78d3e7d1 100644 --- a/spec/features/merge_request/user_posts_diff_notes_spec.rb +++ b/spec/features/merge_request/user_posts_diff_notes_spec.rb @@ -85,12 +85,13 @@ describe 'Merge request > User posts diff notes', :js do # `.line_holder` will be an unfolded line. let(:line_holder) { first('#a5cc2925ca8258af241be7e5b0381edf30266302 .line_holder') } - it 'does not allow commenting on the left side' do - should_not_allow_commenting(line_holder, 'left') + it 'allows commenting on the left side' do + should_allow_commenting(line_holder, 'left') end - it 'does not allow commenting on the right side' do - should_not_allow_commenting(line_holder, 'right') + it 'allows commenting on the right side' do + # Automatically shifts comment box to left side. + should_allow_commenting(line_holder, 'right') end end end @@ -147,8 +148,8 @@ describe 'Merge request > User posts diff notes', :js do # `.line_holder` will be an unfolded line. let(:line_holder) { first('.line_holder[id="a5cc2925ca8258af241be7e5b0381edf30266302_1_1"]') } - it 'does not allow commenting' do - should_not_allow_commenting line_holder + it 'allows commenting' do + should_allow_commenting line_holder end end |