summaryrefslogtreecommitdiff
path: root/spec/features
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2019-05-17 19:10:44 +0700
committerShinya Maeda <shinya@gitlab.com>2019-06-03 10:04:57 +0700
commit6a18a411a30e9e7406ba9335ab502ec396add662 (patch)
tree423c290a2382010561784917effc38d944fdf579 /spec/features
parent96744d0befd7e298c08e6d20a4f504086a717c35 (diff)
downloadgitlab-ce-6a18a411a30e9e7406ba9335ab502ec396add662.tar.gz
Currently, pipeline schedule worker is unstable because it's sometimes killed by excessive memory consumption. In order to improve the performance, we add the following fixes: 1. next_run_at is always real_next_run, which means the value always takes into account of worker's cron schedule 1. Remove exlusive lock. This is already covered by real_next_run change. 1. Use RunPipelineScheduleWorker for avoiding memory killer. Memory consumption is spread to the multiple sidekiq worker.
Diffstat (limited to 'spec/features')
-rw-r--r--spec/features/projects/pipeline_schedules_spec.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/features/projects/pipeline_schedules_spec.rb b/spec/features/projects/pipeline_schedules_spec.rb
index b1a705f09ce..24041a51383 100644
--- a/spec/features/projects/pipeline_schedules_spec.rb
+++ b/spec/features/projects/pipeline_schedules_spec.rb
@@ -225,7 +225,7 @@ describe 'Pipeline Schedules', :js do
context 'when active is true and next_run_at is NULL' do
before do
create(:ci_pipeline_schedule, project: project, owner: user).tap do |pipeline_schedule|
- pipeline_schedule.update_attribute(:cron, nil) # Consequently next_run_at will be nil
+ pipeline_schedule.update_attribute(:next_run_at, nil) # Consequently next_run_at will be nil
end
end