Merge branch '38668-revert-copied-kubernetesservice-logic' into 'master'

Copy `KubernetesService` logic in `Clusters::Platforms::Kubernetes` to make it interchangeable. And implement a selector.

See merge request gitlab-org/gitlab-ce!15515

4 files changed, 126 insertions, 62 deletions

diff --git a/spec/features/auto_deploy_spec.rb b/spec/features/auto_deploy_spec.rb
index 4a7c3e4f1ab..7a395f62511 100644
--- a/spec/features/auto_deploy_spec.rb
+++ b/spec/features/auto_deploy_spec.rb
@@ -4,52 +4,74 @@ describe 'Auto deploy' do
   let(:user) { create(:user) }
   let(:project) { create(:project, :repository) }
 
-  before do
-    create :kubernetes_service, project: project
-    project.team << [user, :master]
-    sign_in user
-  end
+  shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
+    context 'when no deployment service is active' do
+      before do
+        trun_off
+      end
 
-  context 'when no deployment service is active' do
-    before do
-      project.kubernetes_service.update!(active: false)
+      it 'does not show a button to set up auto deploy' do
+        visit project_path(project)
+        expect(page).to have_no_content('Set up auto deploy')
+      end
     end
 
-    it 'does not show a button to set up auto deploy' do
-      visit project_path(project)
-      expect(page).to have_no_content('Set up auto deploy')
+    context 'when a deployment service is active' do
+      before do
+        trun_on
+        visit project_path(project)
+      end
+
+      it 'shows a button to set up auto deploy' do
+        expect(page).to have_link('Set up auto deploy')
+      end
+
+      it 'includes OpenShift as an available template', :js do
+        click_link 'Set up auto deploy'
+        click_button 'Apply a GitLab CI Yaml template'
+
+        within '.gitlab-ci-yml-selector' do
+          expect(page).to have_content('OpenShift')
+        end
+      end
+
+      it 'creates a merge request using "auto-deploy" branch', :js do
+        click_link 'Set up auto deploy'
+        click_button 'Apply a GitLab CI Yaml template'
+        within '.gitlab-ci-yml-selector' do
+          click_on 'OpenShift'
+        end
+        wait_for_requests
+        click_button 'Commit changes'
+
+        expect(page).to have_content('New Merge Request From auto-deploy into master')
+      end
     end
   end
 
-  context 'when a deployment service is active' do
+  context 'when user configured kubernetes from Integration > Kubernetes' do
     before do
-      project.kubernetes_service.update!(active: true)
-      visit project_path(project)
+      create :kubernetes_service, project: project
+      project.team << [user, :master]
+      sign_in user
     end
 
-    it 'shows a button to set up auto deploy' do
-      expect(page).to have_link('Set up auto deploy')
-    end
+    let(:trun_on) { project.deployment_platform.update!(active: true) }
+    let(:trun_off) { project.deployment_platform.update!(active: false) }
 
-    it 'includes OpenShift as an available template', :js do
-      click_link 'Set up auto deploy'
-      click_button 'Apply a GitLab CI Yaml template'
+    it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
+  end
 
-      within '.gitlab-ci-yml-selector' do
-        expect(page).to have_content('OpenShift')
-      end
+  context 'when user configured kubernetes from CI/CD > Clusters' do
+    before do
+      create(:cluster, :provided_by_gcp, projects: [project])
+      project.team << [user, :master]
+      sign_in user
     end
 
-    it 'creates a merge request using "auto-deploy" branch', :js do
-      click_link 'Set up auto deploy'
-      click_button 'Apply a GitLab CI Yaml template'
-      within '.gitlab-ci-yml-selector' do
-        click_on 'OpenShift'
-      end
-      wait_for_requests
-      click_button 'Commit changes'
+    let(:trun_on) { project.deployment_platform.cluster.update!(enabled: true) }
+    let(:trun_off) { project.deployment_platform.cluster.update!(enabled: false) }
 
-      expect(page).to have_content('New Merge Request From auto-deploy into master')
-    end
+    it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
   end
 end
diff --git a/spec/features/projects/clusters/interchangeability_spec.rb b/spec/features/projects/clusters/interchangeability_spec.rb
new file mode 100644
index 00000000000..01f9526608f
--- /dev/null
+++ b/spec/features/projects/clusters/interchangeability_spec.rb
@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+feature 'Interchangeability between KubernetesService and Platform::Kubernetes' do
+  EXCEPT_METHODS = %i[test title description help fields initialize_properties namespace namespace= api_url api_url=].freeze
+  EXCEPT_METHODS_GREP_V = %w[_touched? _changed? _was].freeze
+
+  it 'Clusters::Platform::Kubernetes covers core interfaces in KubernetesService' do
+    expected_interfaces = KubernetesService.instance_methods(false)
+    expected_interfaces = expected_interfaces - EXCEPT_METHODS
+    EXCEPT_METHODS_GREP_V.each do |g|
+      expected_interfaces = expected_interfaces.grep_v(/#{Regexp.escape(g)}\z/)
+    end
+
+    expect(expected_interfaces - Clusters::Platforms::Kubernetes.instance_methods).to be_empty
+  end
+end
diff --git a/spec/features/projects/environments/environment_spec.rb b/spec/features/projects/environments/environment_spec.rb
index 5fc3ba54f65..dfcf97ad495 100644
--- a/spec/features/projects/environments/environment_spec.rb
+++ b/spec/features/projects/environments/environment_spec.rb
@@ -101,35 +101,48 @@ feature 'Environment' do
           end
 
           context 'with terminal' do
-            let(:project) { create(:kubernetes_project, :test_repo) }
+            shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
+              context 'for project master' do
+                let(:role) { :master }
 
-            context 'for project master' do
-              let(:role) { :master }
+                scenario 'it shows the terminal button' do
+                  expect(page).to have_terminal_button
+                end
 
-              scenario 'it shows the terminal button' do
-                expect(page).to have_terminal_button
+                context 'web terminal', :js do
+                  before do
+                    # Stub #terminals as it causes js-enabled feature specs to render the page incorrectly
+                    allow_any_instance_of(Environment).to receive(:terminals) { nil }
+                    visit terminal_project_environment_path(project, environment)
+                  end
+
+                  it 'displays a web terminal' do
+                    expect(page).to have_selector('#terminal')
+                    expect(page).to have_link(nil, href: environment.external_url)
+                  end
+                end
               end
 
-              context 'web terminal', :js do
-                before do
-                  # Stub #terminals as it causes js-enabled feature specs to render the page incorrectly
-                  allow_any_instance_of(Environment).to receive(:terminals) { nil }
-                  visit terminal_project_environment_path(project, environment)
-                end
+              context 'for developer' do
+                let(:role) { :developer }
 
-                it 'displays a web terminal' do
-                  expect(page).to have_selector('#terminal')
-                  expect(page).to have_link(nil, href: environment.external_url)
+                scenario 'does not show terminal button' do
+                  expect(page).not_to have_terminal_button
                 end
               end
             end
 
-            context 'for developer' do
-              let(:role) { :developer }
+            context 'when user configured kubernetes from Integration > Kubernetes' do
+              let(:project) { create(:kubernetes_project, :test_repo) }
 
-              scenario 'does not show terminal button' do
-                expect(page).not_to have_terminal_button
-              end
+              it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
+            end
+
+            context 'when user configured kubernetes from CI/CD > Clusters' do
+              let!(:cluster) { create(:cluster, :project, :provided_by_gcp) }
+              let(:project) { cluster.project }
+
+              it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
             end
           end
 
diff --git a/spec/features/projects/environments/environments_spec.rb b/spec/features/projects/environments/environments_spec.rb
index 879ee6f4b9b..4a05313c14a 100644
--- a/spec/features/projects/environments/environments_spec.rb
+++ b/spec/features/projects/environments/environments_spec.rb
@@ -208,22 +208,35 @@ feature 'Environments page', :js do
         end
 
         context 'when kubernetes terminal is available' do
-          let(:project) { create(:kubernetes_project, :test_repo) }
+          shared_examples 'same behavior between KubernetesService and Platform::Kubernetes' do
+            context 'for project master' do
+              let(:role) { :master }
 
-          context 'for project master' do
-            let(:role) { :master }
+              it 'shows the terminal button' do
+                expect(page).to have_terminal_button
+              end
+            end
+
+            context 'when user is a developer' do
+              let(:role) { :developer }
 
-            it 'shows the terminal button' do
-              expect(page).to have_terminal_button
+              it 'does not show terminal button' do
+                expect(page).not_to have_terminal_button
+              end
             end
           end
 
-          context 'when user is a developer' do
-            let(:role) { :developer }
+          context 'when user configured kubernetes from Integration > Kubernetes' do
+            let(:project) { create(:kubernetes_project, :test_repo) }
 
-            it 'does not show terminal button' do
-              expect(page).not_to have_terminal_button
-            end
+            it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
+          end
+
+          context 'when user configured kubernetes from CI/CD > Clusters' do
+            let(:cluster) { create(:cluster, :provided_by_gcp, projects: [create(:project, :repository)]) }
+            let(:project) { cluster.project }
+
+            it_behaves_like 'same behavior between KubernetesService and Platform::Kubernetes'
           end
         end
       end