diff options
| author | Patrick Bajao <ebajao@gitlab.com> | 2019-04-11 15:49:53 -0800 |
|---|---|---|
| committer | Patrick Bajao <ebajao@gitlab.com> | 2019-04-11 15:49:53 +0800 |
| commit | 171818df0a72097aa1a804c8213666b3f66b0966 (patch) | |
| tree | ba412628c7f5a23fe31622f0e22af01bc9288855 /spec/features | |
| parent | a4262919f76d7d2f82754753dc03b6d2bf310905 (diff) | |
| download | gitlab-ce-171818df0a72097aa1a804c8213666b3f66b0966.tar.gz | |
Revert "Merge branch '24704-download-repository-path' into 'master'"revert-24704-download-repository-path
This reverts commit 6c75bd015cba181f028bc87c396c3d8e43b5dc3e, reversing
changes made to 1be7f5aaa38aba79843eae8835be6c99c025e982.
Diffstat (limited to 'spec/features')
4 files changed, 5 insertions, 4 deletions
diff --git a/spec/features/projects/branches/download_buttons_spec.rb b/spec/features/projects/branches/download_buttons_spec.rb index 3e75890725e..c8dc72a34ec 100644 --- a/spec/features/projects/branches/download_buttons_spec.rb +++ b/spec/features/projects/branches/download_buttons_spec.rb @@ -35,7 +35,7 @@ describe 'Download buttons in branches page' do it 'shows download artifacts button' do href = latest_succeeded_project_artifacts_path(project, 'binary-encoding/download', job: 'build') - expect(page).to have_link build.name, href: href + expect(page).to have_link "Download '#{build.name}'", href: href end end end diff --git a/spec/features/projects/files/download_buttons_spec.rb b/spec/features/projects/files/download_buttons_spec.rb index 111972a6b00..03cb3530e2b 100644 --- a/spec/features/projects/files/download_buttons_spec.rb +++ b/spec/features/projects/files/download_buttons_spec.rb @@ -30,7 +30,7 @@ describe 'Projects > Files > Download buttons in files tree' do it 'shows download artifacts button' do href = latest_succeeded_project_artifacts_path(project, "#{project.default_branch}/download", job: 'build') - expect(page).to have_link build.name, href: href + expect(page).to have_link "Download '#{build.name}'", href: href end end end diff --git a/spec/features/projects/show/download_buttons_spec.rb b/spec/features/projects/show/download_buttons_spec.rb index fee5f8001b0..3a2dcc5aa55 100644 --- a/spec/features/projects/show/download_buttons_spec.rb +++ b/spec/features/projects/show/download_buttons_spec.rb @@ -35,10 +35,11 @@ describe 'Projects > Show > Download buttons' do it 'shows download artifacts button' do href = latest_succeeded_project_artifacts_path(project, "#{project.default_branch}/download", job: 'build') - expect(page).to have_link build.name, href: href + expect(page).to have_link "Download '#{build.name}'", href: href end it 'download links have download attribute' do + expect(page).to have_selector('a', text: 'Download') page.all('a', text: 'Download').each do |link| expect(link[:download]).to eq '' end diff --git a/spec/features/projects/tags/download_buttons_spec.rb b/spec/features/projects/tags/download_buttons_spec.rb index 4c8ec53836a..fbfd8cee7aa 100644 --- a/spec/features/projects/tags/download_buttons_spec.rb +++ b/spec/features/projects/tags/download_buttons_spec.rb @@ -36,7 +36,7 @@ describe 'Download buttons in tags page' do it 'shows download artifacts button' do href = latest_succeeded_project_artifacts_path(project, "#{tag}/download", job: 'build') - expect(page).to have_link build.name, href: href + expect(page).to have_link "Download '#{build.name}'", href: href end end end |