summaryrefslogtreecommitdiff
path: root/spec/features
diff options
context:
space:
mode:
authorLuke Bennett <lbennett@gitlab.com>2018-11-14 19:51:39 +0000
committerLuke Bennett <lbennett@gitlab.com>2019-01-22 02:04:32 +0000
commit88ce491fc981527ec864176e84332ecb7b8ac0ce (patch)
tree96f3d830af04995f54464f603f48a90199687c79 /spec/features
parent94d05e3c5ce59448d63ee96e3474b0cd3ef2c995 (diff)
downloadgitlab-ce-88ce491fc981527ec864176e84332ecb7b8ac0ce.tar.gz
Fix DirtySubmit handling of checkbox and radio inputs
Most browsers do not fire the "input" event for checkboxes or radios. Adds a "change" listener to properly trigger these DirtySubmit updates.
Diffstat (limited to 'spec/features')
-rw-r--r--spec/features/groups_spec.rb4
1 files changed, 3 insertions, 1 deletions
diff --git a/spec/features/groups_spec.rb b/spec/features/groups_spec.rb
index d01fc04311a..00d81b26ce2 100644
--- a/spec/features/groups_spec.rb
+++ b/spec/features/groups_spec.rb
@@ -154,7 +154,7 @@ describe 'Group' do
end
describe 'group edit', :js do
- let(:group) { create(:group) }
+ let(:group) { create(:group, :public) }
let(:path) { edit_group_path(group) }
let(:new_name) { 'new-name' }
@@ -163,6 +163,8 @@ describe 'Group' do
end
it_behaves_like 'dirty submit form', [{ form: '.js-general-settings-form', input: 'input[name="group[name]"]' },
+ { form: '.js-general-settings-form', input: '#group_visibility_level_0' },
+ { form: '.js-general-permissions-form', input: '#group_request_access_enabled' },
{ form: '.js-general-permissions-form', input: 'input[name="group[two_factor_grace_period]"]' }]
it 'saves new settings' do