Make use of to_reference in more specs

1 files changed, 17 insertions, 17 deletions

diff --git a/spec/features/gitlab_flavored_markdown_spec.rb b/spec/features/gitlab_flavored_markdown_spec.rb
index 133beba7b98..16d1ca55f8d 100644
--- a/spec/features/gitlab_flavored_markdown_spec.rb
+++ b/spec/features/gitlab_flavored_markdown_spec.rb
@@ -11,7 +11,7 @@ describe "GitLab Flavored Markdown", feature: true do
   end
 
   before do
-    Commit.any_instance.stub(title: "fix ##{issue.iid}\n\nask @#{fred.username} for details")
+    Commit.any_instance.stub(title: "fix #{issue.to_reference}\n\nask #{fred.to_reference} for details")
   end
 
   let(:commit) { project.commit }
@@ -25,25 +25,25 @@ describe "GitLab Flavored Markdown", feature: true do
     it "should render title in commits#index" do
       visit namespace_project_commits_path(project.namespace, project, 'master', limit: 1)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
 
     it "should render title in commits#show" do
       visit namespace_project_commit_path(project.namespace, project, commit)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
 
     it "should render description in commits#show" do
       visit namespace_project_commit_path(project.namespace, project, commit)
 
-      expect(page).to have_link("@#{fred.username}")
+      expect(page).to have_link(fred.to_reference)
     end
 
     it "should render title in repositories#branches" do
       visit namespace_project_branches_path(project.namespace, project)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
   end
 
@@ -57,20 +57,20 @@ describe "GitLab Flavored Markdown", feature: true do
                       author: @user,
                       assignee: @user,
                       project: project,
-                      title: "fix ##{@other_issue.iid}",
-                      description: "ask @#{fred.username} for details")
+                      title: "fix #{@other_issue.to_reference}",
+                      description: "ask #{fred.to_reference} for details")
     end
 
     it "should render subject in issues#index" do
       visit namespace_project_issues_path(project.namespace, project)
 
-      expect(page).to have_link("##{@other_issue.iid}")
+      expect(page).to have_link(@other_issue.to_reference)
     end
 
     it "should render subject in issues#show" do
       visit namespace_project_issue_path(project.namespace, project, @issue)
 
-      expect(page).to have_link("##{@other_issue.iid}")
+      expect(page).to have_link(@other_issue.to_reference)
     end
 
     it "should render details in issues#show" do
@@ -83,19 +83,19 @@ describe "GitLab Flavored Markdown", feature: true do
 
   describe "for merge requests" do
     before do
-      @merge_request = create(:merge_request, source_project: project, target_project: project, title: "fix ##{issue.iid}")
+      @merge_request = create(:merge_request, source_project: project, target_project: project, title: "fix #{issue.to_reference}")
     end
 
     it "should render title in merge_requests#index" do
       visit namespace_project_merge_requests_path(project.namespace, project)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
 
     it "should render title in merge_requests#show" do
       visit namespace_project_merge_request_path(project.namespace, project, @merge_request)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
   end
 
@@ -104,26 +104,26 @@ describe "GitLab Flavored Markdown", feature: true do
     before do
       @milestone = create(:milestone,
                           project: project,
-                          title: "fix ##{issue.iid}",
-                          description: "ask @#{fred.username} for details")
+                          title: "fix #{issue.to_reference}",
+                          description: "ask #{fred.to_reference} for details")
     end
 
     it "should render title in milestones#index" do
       visit namespace_project_milestones_path(project.namespace, project)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
 
     it "should render title in milestones#show" do
       visit namespace_project_milestone_path(project.namespace, project, @milestone)
 
-      expect(page).to have_link("##{issue.iid}")
+      expect(page).to have_link(issue.to_reference)
     end
 
     it "should render description in milestones#show" do
       visit namespace_project_milestone_path(project.namespace, project, @milestone)
 
-      expect(page).to have_link("@#{fred.username}")
+      expect(page).to have_link(fred.to_reference)
     end
   end
 end