summaryrefslogtreecommitdiff
path: root/spec/features
diff options
context:
space:
mode:
authorShinya Maeda <shinya@gitlab.com>2019-08-27 10:51:28 +0700
committerShinya Maeda <shinya@gitlab.com>2019-08-30 18:45:00 +0700
commitf246db4446466de58ba8618fb77bea63ca976551 (patch)
tree2731e145a0d7c77230de01e3c1c3d6b30d8efffb /spec/features
parent153f25af9ccb3b35f0dc4111afc4da5112c27b13 (diff)
downloadgitlab-ce-f246db4446466de58ba8618fb77bea63ca976551.tar.gz
Fix deployable nil exception on job controllerfix-nil-deployable-exception-on-job-controller-show
When deployable is nil, we gracefully take care of the case.
Diffstat (limited to 'spec/features')
-rw-r--r--spec/features/projects/jobs_spec.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/features/projects/jobs_spec.rb b/spec/features/projects/jobs_spec.rb
index 8ed420300af..eb52df2ff79 100644
--- a/spec/features/projects/jobs_spec.rb
+++ b/spec/features/projects/jobs_spec.rb
@@ -609,6 +609,14 @@ describe 'Jobs', :clean_gitlab_redis_shared_state do
expect(find('.js-environment-link')['href']).to match("environments/#{environment.id}")
expect(find('.js-job-deployment-link')['href']).to include(second_deployment.deployable.project.path, second_deployment.deployable_id.to_s)
end
+
+ context 'when deployment does not have a deployable' do
+ let!(:second_deployment) { create(:deployment, :success, environment: environment, deployable: nil) }
+
+ it 'has an empty href' do
+ expect(find('.js-job-deployment-link')['href']).to be_empty
+ end
+ end
end
context 'job failed to deploy' do