Replace the 'features/explore/projects.feature' spinach test with an rspec analogreplace_explore_projects.feature

5 files changed, 372 insertions, 70 deletions

diff --git a/spec/features/explore/user_explores_projects_spec.rb b/spec/features/explore/user_explores_projects_spec.rb
new file mode 100644
index 00000000000..6ac9497b024
--- /dev/null
+++ b/spec/features/explore/user_explores_projects_spec.rb
@@ -0,0 +1,72 @@
+require 'spec_helper'
+
+describe 'User explores projects' do
+  set(:archived_project) { create(:project, :archived) }
+  set(:internal_project) { create(:project, :internal) }
+  set(:private_project) { create(:project, :private) }
+  set(:public_project) { create(:project, :public) }
+
+  shared_examples_for 'shows public projects' do
+    it 'shows projects' do
+      expect(page).to have_content(public_project.title)
+      expect(page).not_to have_content(internal_project.title)
+      expect(page).not_to have_content(private_project.title)
+      expect(page).not_to have_content(archived_project.title)
+    end
+  end
+
+  shared_examples_for 'shows public and internal projects' do
+    it 'shows projects' do
+      expect(page).to have_content(public_project.title)
+      expect(page).to have_content(internal_project.title)
+      expect(page).not_to have_content(private_project.title)
+      expect(page).not_to have_content(archived_project.title)
+    end
+  end
+
+  context 'when not signed in' do
+    context 'when viewing public projects' do
+      before do
+        visit(explore_projects_path)
+      end
+
+      include_examples 'shows public projects'
+    end
+  end
+
+  context 'when signed in' do
+    set(:user) { create(:user) }
+
+    before do
+      sign_in(user)
+    end
+
+    context 'when viewing public projects' do
+      before do
+        visit(explore_projects_path)
+      end
+
+      include_examples 'shows public and internal projects'
+    end
+
+    context 'when viewing most starred projects' do
+      before do
+        visit(starred_explore_projects_path)
+      end
+
+      include_examples 'shows public and internal projects'
+    end
+
+    context 'when viewing trending projects' do
+      before do
+        [archived_project, public_project].each { |project| create(:note_on_issue, project: project) }
+
+        TrendingProject.refresh!
+
+        visit(trending_explore_projects_path)
+      end
+
+      include_examples 'shows public projects'
+    end
+  end
+end
diff --git a/spec/features/projects/issues/list_spec.rb b/spec/features/projects/issues/list_spec.rb
deleted file mode 100644
index 9fc03f49f5b..00000000000
--- a/spec/features/projects/issues/list_spec.rb
+++ /dev/null
@@ -1,20 +0,0 @@
-require 'spec_helper'
-
-feature 'Issues List' do
-  let(:user) { create(:user) }
-  let(:project) { create(:project) }
-
-  background do
-    project.team << [user, :developer]
-
-    sign_in(user)
-  end
-
-  scenario 'user does not see create new list button' do
-    create(:issue, project: project)
-
-    visit project_issues_path(project)
-
-    expect(page).not_to have_selector('.js-new-board-list')
-  end
-end
diff --git a/spec/features/projects/issues/user_views_issues_spec.rb b/spec/features/projects/issues/user_views_issues_spec.rb
new file mode 100644
index 00000000000..d35009b8974
--- /dev/null
+++ b/spec/features/projects/issues/user_views_issues_spec.rb
@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe 'User views issues' do
+  set(:user) { create(:user) }
+
+  shared_examples_for 'shows issues' do
+    it 'shows issues' do
+      expect(page).to have_content(project.name)
+        .and have_content(issue1.title)
+        .and have_content(issue2.title)
+        .and have_no_selector('.js-new-board-list')
+    end
+  end
+
+  context 'when project is public' do
+    set(:project) { create(:project_empty_repo, :public) }
+    set(:issue1) { create(:issue, project: project) }
+    set(:issue2) { create(:issue, project: project) }
+
+    context 'when signed in' do
+      before do
+        project.add_developer(user)
+        sign_in(user)
+
+        visit(project_issues_path(project))
+      end
+
+      include_examples 'shows issues'
+    end
+
+    context 'when not signed in' do
+      before do
+        visit(project_issues_path(project))
+      end
+
+      include_examples 'shows issues'
+    end
+  end
+
+  context 'when project is internal' do
+    set(:project) { create(:project_empty_repo, :internal) }
+    set(:issue1) { create(:issue, project: project) }
+    set(:issue2) { create(:issue, project: project) }
+
+    context 'when signed in' do
+      before do
+        project.add_developer(user)
+        sign_in(user)
+
+        visit(project_issues_path(project))
+      end
+
+      include_examples 'shows issues'
+    end
+  end
+end
diff --git a/spec/features/projects/merge_requests/user_views_open_merge_requests_spec.rb b/spec/features/projects/merge_requests/user_views_open_merge_requests_spec.rb
index 07b8c1ef479..bf95dbb7d09 100644
--- a/spec/features/projects/merge_requests/user_views_open_merge_requests_spec.rb
+++ b/spec/features/projects/merge_requests/user_views_open_merge_requests_spec.rb
@@ -1,72 +1,115 @@
 require 'spec_helper'
 
 describe 'User views open merge requests' do
-  let(:project) { create(:project, :public, :repository) }
+  set(:user) { create(:user) }
 
-  context "when the target branch is the project's default branch" do
-    let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
-    let!(:closed_merge_request) { create(:closed_merge_request, source_project: project, target_project: project) }
-
-    before do
-      visit(project_merge_requests_path(project))
+  shared_examples_for 'shows merge requests' do
+    it 'shows merge requests' do
+      expect(page).to have_content(project.name).and have_content(merge_request.source_project.name)
     end
+  end
 
-    it 'shows open merge requests' do
-      expect(page).to have_content(merge_request.title).and have_no_content(closed_merge_request.title)
-    end
+  context 'when project is public' do
+    set(:project) { create(:project, :public, :repository) }
 
-    it 'does not show target branch name' do
-      expect(page).to have_content(merge_request.title)
-      expect(find('.issuable-info')).not_to have_content(project.default_branch)
-    end
-  end
+    context 'when not signed in' do
+      context "when the target branch is the project's default branch" do
+        let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
+        let!(:closed_merge_request) { create(:closed_merge_request, source_project: project, target_project: project) }
 
-  context "when the target branch is different from the project's default branch" do
-    let!(:merge_request) do
-      create(:merge_request,
-        source_project: project,
-        target_project: project,
-        source_branch: 'fix',
-        target_branch: 'feature_conflict')
-    end
+        before do
+          visit(project_merge_requests_path(project))
+        end
 
-    before do
-      visit(project_merge_requests_path(project))
-    end
+        include_examples 'shows merge requests'
 
-    it 'shows target branch name' do
-      expect(page).to have_content(merge_request.target_branch)
-    end
-  end
+        it 'shows open merge requests' do
+          expect(page).to have_content(merge_request.title).and have_no_content(closed_merge_request.title)
+        end
 
-  context 'when a merge request has pipelines' do
-    let!(:build) { create :ci_build, pipeline: pipeline }
+        it 'does not show target branch name' do
+          expect(page).to have_content(merge_request.title)
+          expect(find('.issuable-info')).not_to have_content(project.default_branch)
+        end
+      end
 
-    let(:merge_request) do
-      create(:merge_request_with_diffs,
-       source_project: project,
-       target_project: project,
-       source_branch: 'merge-test')
-    end
+      context "when the target branch is different from the project's default branch" do
+        let!(:merge_request) do
+          create(:merge_request,
+            source_project: project,
+            target_project: project,
+            source_branch: 'fix',
+            target_branch: 'feature_conflict')
+        end
+
+        before do
+          visit(project_merge_requests_path(project))
+        end
+
+        it 'shows target branch name' do
+          expect(page).to have_content(merge_request.target_branch)
+        end
+      end
 
-    let(:pipeline) do
-      create(:ci_pipeline,
-        project: project,
-        sha: merge_request.diff_head_sha,
-        ref: merge_request.source_branch,
-        head_pipeline_of: merge_request)
+      context 'when a merge request has pipelines' do
+        let!(:build) { create :ci_build, pipeline: pipeline }
+
+        let(:merge_request) do
+          create(:merge_request_with_diffs,
+          source_project: project,
+          target_project: project,
+          source_branch: 'merge-test')
+        end
+
+        let(:pipeline) do
+          create(:ci_pipeline,
+            project: project,
+            sha: merge_request.diff_head_sha,
+            ref: merge_request.source_branch,
+            head_pipeline_of: merge_request)
+        end
+
+        before do
+          project.enable_ci
+
+          visit(project_merge_requests_path(project))
+        end
+
+        it 'shows pipeline status' do
+          page.within('.mr-list') do
+            expect(page).to have_link('Pipeline: pending')
+          end
+        end
+      end
     end
 
-    before do
-      project.enable_ci
+    context 'when signed in' do
+      let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
+
+      before do
+        project.add_developer(user)
+        sign_in(user)
 
-      visit(project_merge_requests_path(project))
+        visit(project_merge_requests_path(project))
+      end
+
+      include_examples 'shows merge requests'
     end
+  end
 
-    it 'shows pipeline status' do
-      page.within('.mr-list') do
-        expect(page).to have_link('Pipeline: pending')
+  context 'when project is internal' do
+    let!(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
+    set(:project) { create(:project, :internal, :repository) }
+
+    context 'when signed in' do
+      before do
+        project.add_developer(user)
+        sign_in(user)
+
+        visit(project_merge_requests_path(project))
       end
+
+      include_examples 'shows merge requests'
     end
   end
 end
diff --git a/spec/features/projects/user_views_details_spec.rb b/spec/features/projects/user_views_details_spec.rb
new file mode 100644
index 00000000000..ffc063654cd
--- /dev/null
+++ b/spec/features/projects/user_views_details_spec.rb
@@ -0,0 +1,151 @@
+require 'spec_helper'
+
+describe 'User views details' do
+  set(:user) { create(:user) }
+
+  shared_examples_for 'redirects to the sign in page' do
+    it 'redirects to the sign in page' do
+      expect(current_path).to eq(new_user_session_path)
+    end
+  end
+
+  shared_examples_for 'shows details of empty project' do
+    let(:user_has_ssh_key) { false }
+
+    it 'shows details' do
+      expect(page).not_to have_content('Git global setup')
+
+      page.all(:css, '.git-empty .clone').each do |element|
+        expect(element.text).to include(project.http_url_to_repo)
+      end
+
+      expect(page).to have_field('project_clone', with: project.http_url_to_repo) unless user_has_ssh_key
+    end
+  end
+
+  shared_examples_for 'shows details of non empty project' do
+    let(:user_has_ssh_key) { false }
+
+    it 'shows details' do
+      page.within('.breadcrumbs .breadcrumb-item-text') do
+        expect(page).to have_content(project.title)
+      end
+
+      expect(page).to have_field('project_clone', with: project.http_url_to_repo) unless user_has_ssh_key
+    end
+  end
+
+  context 'when project is public' do
+    context 'when project is empty' do
+      set(:project) { create(:project_empty_repo, :public) }
+
+      context 'when not signed in' do
+        before do
+          visit(project_path(project))
+        end
+
+        include_examples 'shows details of empty project'
+      end
+
+      context 'when signed in' do
+        before do
+          sign_in(user)
+        end
+
+        context 'when user does not have ssh keys' do
+          before do
+            visit(project_path(project))
+          end
+
+          include_examples 'shows details of empty project'
+        end
+
+        context 'when user has ssh keys' do
+          before do
+            create(:personal_key, user: user)
+
+            visit(project_path(project))
+          end
+
+          include_examples 'shows details of empty project' do
+            let(:user_has_ssh_key) { true }
+          end
+        end
+      end
+    end
+
+    context 'when project is not empty' do
+      set(:project) { create(:project, :public, :repository) }
+
+      before do
+        visit(project_path(project))
+      end
+
+      context 'when not signed in' do
+        before do
+          allow(Gitlab.config.gitlab).to receive(:host).and_return('www.example.com')
+        end
+
+        include_examples 'shows details of non empty project'
+      end
+
+      context 'when signed in' do
+        before do
+          sign_in(user)
+        end
+
+        context 'when user does not have ssh keys' do
+          before do
+            visit(project_path(project))
+          end
+
+          include_examples 'shows details of non empty project'
+        end
+
+        context 'when user has ssh keys' do
+          before do
+            create(:personal_key, user: user)
+
+            visit(project_path(project))
+          end
+
+          include_examples 'shows details of non empty project' do
+            let(:user_has_ssh_key) { true }
+          end
+        end
+      end
+    end
+  end
+
+  context 'when project is internal' do
+    set(:project) { create(:project, :internal, :repository) }
+
+    context 'when not signed in' do
+      before do
+        visit(project_path(project))
+      end
+
+      include_examples 'redirects to the sign in page'
+    end
+
+    context 'when signed in' do
+      before do
+        sign_in(user)
+
+        visit(project_path(project))
+      end
+
+      include_examples 'shows details of non empty project'
+    end
+  end
+
+  context 'when project is private' do
+    set(:project) { create(:project, :private) }
+
+    before do
+      visit(project_path(project))
+    end
+
+    include_examples 'redirects to the sign in page'
+  end
+end