Add latest changes from gitlab-org/gitlab@13-4-stable-ee

1 files changed, 94 insertions, 0 deletions

diff --git a/spec/finders/feature_flags_finder_spec.rb b/spec/finders/feature_flags_finder_spec.rb
new file mode 100644
index 00000000000..870447a1286
--- /dev/null
+++ b/spec/finders/feature_flags_finder_spec.rb
@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe FeatureFlagsFinder do
+  include FeatureFlagHelpers
+
+  let(:finder) { described_class.new(project, user, params) }
+  let(:project) { create(:project) }
+  let(:user) { developer }
+  let(:developer) { create(:user) }
+  let(:reporter) { create(:user) }
+  let(:params) { {} }
+
+  before do
+    project.add_developer(developer)
+    project.add_reporter(reporter)
+  end
+
+  describe '#execute' do
+    subject { finder.execute(args) }
+
+    let!(:feature_flag_1) { create(:operations_feature_flag, name: 'flag-a', project: project) }
+    let!(:feature_flag_2) { create(:operations_feature_flag, name: 'flag-b', project: project) }
+    let(:args) { {} }
+
+    it 'returns feature flags ordered by name' do
+      is_expected.to eq([feature_flag_1, feature_flag_2])
+    end
+
+    it 'preloads relations by default' do
+      expect(Operations::FeatureFlag).to receive(:preload_relations).and_call_original
+
+      subject
+    end
+
+    context 'when user is a reporter' do
+      let(:user) { reporter }
+
+      it 'returns an empty list' do
+        is_expected.to be_empty
+      end
+    end
+
+    context 'when scope is given' do
+      let!(:feature_flag_1) { create(:operations_feature_flag, project: project, active: true) }
+      let!(:feature_flag_2) { create(:operations_feature_flag, project: project, active: false) }
+
+      context 'when scope is enabled' do
+        let(:params) { { scope: 'enabled' } }
+
+        it 'returns active feature flag' do
+          is_expected.to eq([feature_flag_1])
+        end
+      end
+
+      context 'when scope is disabled' do
+        let(:params) { { scope: 'disabled' } }
+
+        it 'returns inactive feature flag' do
+          is_expected.to eq([feature_flag_2])
+        end
+      end
+    end
+
+    context 'when preload option is false' do
+      let(:args) { { preload: false } }
+
+      it 'does not preload relations' do
+        expect(Operations::FeatureFlag).not_to receive(:preload_relations)
+
+        subject
+      end
+    end
+
+    context 'when new version flags are enabled' do
+      let!(:feature_flag_3) { create(:operations_feature_flag, :new_version_flag, name: 'flag-c', project: project) }
+
+      it 'returns new and legacy flags' do
+        is_expected.to eq([feature_flag_1, feature_flag_2, feature_flag_3])
+      end
+    end
+
+    context 'when new version flags are disabled' do
+      let!(:feature_flag_3) { create(:operations_feature_flag, :new_version_flag, name: 'flag-c', project: project) }
+
+      it 'returns only legacy flags' do
+        stub_feature_flags(feature_flags_new_version: false)
+
+        is_expected.to eq([feature_flag_1, feature_flag_2])
+      end
+    end
+  end
+end