diff options
author | Alexis Reigel <alexis.reigel.ext@siemens.com> | 2019-02-21 20:26:54 +0100 |
---|---|---|
committer | Alexis Reigel <alexis.reigel.ext@siemens.com> | 2019-02-27 20:20:24 +0100 |
commit | 0853c234fc39dcfd70175d86990089712c462d58 (patch) | |
tree | d1e726d12181c02f73b514daa7a7880d29b33b6c /spec/finders | |
parent | 28fcf5c4bfe19dfb90363e201156ad68b7263f6d (diff) | |
download | gitlab-ce-0853c234fc39dcfd70175d86990089712c462d58.tar.gz |
make assertions on objects instead of tag names
Diffstat (limited to 'spec/finders')
-rw-r--r-- | spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb b/spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb index 857f6bba7e6..79d2f9cdb45 100644 --- a/spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb +++ b/spec/finders/autocomplete/acts_as_taggable_on/tags_finder_spec.rb @@ -6,12 +6,12 @@ describe Autocomplete::ActsAsTaggableOn::TagsFinder do describe '#execute' do context 'with empty params' do it 'returns all tags' do - ActsAsTaggableOn::Tag.create!(name: 'tag1') - ActsAsTaggableOn::Tag.create!(name: 'tag2') + tag1 = ActsAsTaggableOn::Tag.create!(name: 'tag1') + tag2 = ActsAsTaggableOn::Tag.create!(name: 'tag2') - tags = described_class.new(params: {}).execute.map(&:name) + tags = described_class.new(params: {}).execute - expect(tags).to match_array %w(tag1 tag2) + expect(tags).to match_array [tag1, tag2] end end @@ -21,7 +21,7 @@ describe Autocomplete::ActsAsTaggableOn::TagsFinder do ActsAsTaggableOn::Tag.create!(name: 'tag1') ActsAsTaggableOn::Tag.create!(name: 'tag2') - tags = described_class.new(params: { search: '' }).execute.map(&:name) + tags = described_class.new(params: { search: '' }).execute expect(tags).to be_empty end @@ -29,23 +29,23 @@ describe Autocomplete::ActsAsTaggableOn::TagsFinder do context 'with a search containing 2 characters' do it 'returns the tag that strictly matches the search term' do - ActsAsTaggableOn::Tag.create!(name: 't1') + tag1 = ActsAsTaggableOn::Tag.create!(name: 't1') ActsAsTaggableOn::Tag.create!(name: 't11') - tags = described_class.new(params: { search: 't1' }).execute.map(&:name) + tags = described_class.new(params: { search: 't1' }).execute - expect(tags).to match_array ['t1'] + expect(tags).to match_array [tag1] end end context 'with a search containing 3 characters' do it 'returns the tag that partially matches the search term' do - ActsAsTaggableOn::Tag.create!(name: 'tag1') - ActsAsTaggableOn::Tag.create!(name: 'tag11') + tag1 = ActsAsTaggableOn::Tag.create!(name: 'tag1') + tag2 = ActsAsTaggableOn::Tag.create!(name: 'tag11') - tags = described_class.new(params: { search: 'ag1' }).execute.map(&:name) + tags = described_class.new(params: { search: 'ag1' }).execute - expect(tags).to match_array %w(tag1 tag11) + expect(tags).to match_array [tag1, tag2] end end end |